Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding comments to code that needs to be removed on v3.0 #13588

Merged
merged 5 commits into from
Oct 6, 2021
Merged

Adding comments to code that needs to be removed on v3.0 #13588

merged 5 commits into from
Oct 6, 2021

Conversation

paulomarquesc
Copy link
Contributor

This PR adds the following comment before code that needs to be removed due to deprecation:

// todo remove this in version 3.0 of the provider

@github-actions github-actions bot added the size/S label Oct 1, 2021
katbyte
katbyte requested changes Oct 1, 2021
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

THanks @paulomarquesc - just one comment aside from fixing CI

internal/services/netapp/netapp_snapshot_resource.go Outdated Show resolved Hide resolved
@katbyte katbyte modified the milestones: v3.0.0, v2.80.0 Oct 6, 2021
@katbyte katbyte merged commit bc6076f into hashicorp:main Oct 6, 2021
@github-actions
Copy link

github-actions bot commented Oct 8, 2021

This functionality has been released in v2.80.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Nov 7, 2021

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@katbyte katbyte katbyte approved these changes

Assignees
No one assigned
Labels
documentation service/netapp size/S
Projects
None yet
Milestone
v2.80.0
Development

Successfully merging this pull request may close these issues.
2 participants
@paulomarquesc @katbyte