Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_app_configuration_key: Support for slashes in key #13859

Merged
merged 2 commits into from
Oct 25, 2021

Conversation

aristosvo
Copy link
Collaborator

@aristosvo aristosvo commented Oct 22, 2021

Fixes #13852

Acceptance Tests

❯ go install && make acctests SERVICE='appconfiguration' TESTARGS='-run=TestAccAppConfigurationKey_'
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test -v ./internal/services/appconfiguration -run=TestAccAppConfigurationKey_ -timeout 180m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccAppConfigurationKey_basic
=== PAUSE TestAccAppConfigurationKey_basic
=== RUN   TestAccAppConfigurationKey_basicNoLabel
=== PAUSE TestAccAppConfigurationKey_basicNoLabel
=== RUN   TestAccAppConfigurationKey_basicNoLabel_afterLabel
=== PAUSE TestAccAppConfigurationKey_basicNoLabel_afterLabel
=== RUN   TestAccAppConfigurationKey_basicVault
=== PAUSE TestAccAppConfigurationKey_basicVault
=== RUN   TestAccAppConfigurationKey_KVToVault
=== PAUSE TestAccAppConfigurationKey_KVToVault
=== RUN   TestAccAppConfigurationKey_slash
=== PAUSE TestAccAppConfigurationKey_slash
=== RUN   TestAccAppConfigurationKey_requiresImport
=== PAUSE TestAccAppConfigurationKey_requiresImport
=== RUN   TestAccAppConfigurationKey_lockUpdate
=== PAUSE TestAccAppConfigurationKey_lockUpdate
=== CONT  TestAccAppConfigurationKey_basic
=== CONT  TestAccAppConfigurationKey_slash
=== CONT  TestAccAppConfigurationKey_basicVault
=== CONT  TestAccAppConfigurationKey_KVToVault
=== CONT  TestAccAppConfigurationKey_lockUpdate
=== CONT  TestAccAppConfigurationKey_basicNoLabel
=== CONT  TestAccAppConfigurationKey_requiresImport
=== CONT  TestAccAppConfigurationKey_basicNoLabel_afterLabel
--- PASS: TestAccAppConfigurationKey_slash (124.98s)
--- PASS: TestAccAppConfigurationKey_basic (126.19s)
--- PASS: TestAccAppConfigurationKey_basicNoLabel (127.74s)
--- PASS: TestAccAppConfigurationKey_basicNoLabel_afterLabel (132.11s)
--- PASS: TestAccAppConfigurationKey_requiresImport (136.17s)
--- PASS: TestAccAppConfigurationKey_lockUpdate (162.06s)
--- PASS: TestAccAppConfigurationKey_basicVault (254.18s)
--- PASS: TestAccAppConfigurationKey_KVToVault (317.02s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/appconfiguration      318.602s

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @aristosvo - LGTM 🛻

@katbyte katbyte merged commit 9cf05ee into hashicorp:main Oct 25, 2021
katbyte added a commit that referenced this pull request Oct 25, 2021
@github-actions
Copy link

This functionality has been released in v2.83.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"/" not allowed in the key for azurerm_app_configuration_key resource
2 participants