Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/application_Gateway: Add minimum_servers to probe resource #1510

Merged
merged 2 commits into from
Jul 7, 2018

Conversation

stack72
Copy link
Contributor

@stack72 stack72 commented Jul 6, 2018

This was missing from the original implementation and is required if
you want to manually mark servers as active

Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this otherwise LGTM 👍

@@ -1172,6 +1178,7 @@ func expandApplicationGatewayProbes(d *schema.ResourceData) *[]network.Applicati
interval := int32(data["interval"].(int))
timeout := int32(data["timeout"].(int))
unhealthyThreshold := int32(data["unhealthy_threshold"].(int))
minServers := int32(data["minimum_servers"].(int))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we update one of the existing tests to set this to 2 / verify this assumption?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry for the issues with the names :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

np :)

This was missing from the original implementation and is required if
you want to manually mark servers as active
@stack72 stack72 force-pushed the app_gateway_probe_min_servers branch from cf269c5 to 3078e0d Compare July 6, 2018 13:36
@tombuildsstuff tombuildsstuff added this to the 1.9.0 milestone Jul 6, 2018
@katbyte katbyte merged commit f1b5901 into hashicorp:master Jul 7, 2018
katbyte added a commit that referenced this pull request Jul 7, 2018
@ghost
Copy link

ghost commented Mar 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants