Storage Share Quota and Import Support #1650
Conversation
|
Tests passing |
| storageAccountName := d.Get("storage_account_name").(string) | ||
| id := strings.Split(d.Id(), "/") | ||
| name := id[0] | ||
| resourceGroupName := id[1] |
There was a problem hiding this comment.
as discussed on Slack - there's a crash here until we have a state migration for the ID switch
| // Exists already removed this from state | ||
| return nil | ||
| log.Printf("[INFO] Share %q no longer exists, removing from state...", name) | ||
| d.SetId("") |
There was a problem hiding this comment.
this wants a return nil here
|
|
||
| return resourceArmStorageShareRead(d, meta) | ||
| } | ||
|
|
||
| func resourceArmStorageShareExists(d *schema.ResourceData, meta interface{}) (bool, error) { |
There was a problem hiding this comment.
I think this method can be removed?
|
|
||
| ```shell | ||
| terraform import azurerm_storage_share.testShare storageShareName/resourceGroupName/storageAccoutName | ||
| ``` |
There was a problem hiding this comment.
can we add -> **NOTE:** This identifier is unique to Terraform below this
azurerm/validators.go
Outdated
| @@ -246,3 +246,26 @@ func validateFilePath() schema.SchemaValidateFunc { | |||
| return | |||
| } | |||
| } | |||
|
|
|||
| //Following the naming convention as laid out in the docs https://msdn.microsoft.com/library/azure/dn167011.aspx | |||
| func validateArmStorageShareName(v interface{}, k string) (ws []string, errors []error) { | |||
There was a problem hiding this comment.
since this is the only place it's used, can we move this back into the share resource?
| { | ||
| ResourceName: resourceName, | ||
| ImportState: true, | ||
| ImportStateVerify: true, |
There was a problem hiding this comment.
we can remove the Imports from this test (since they're covered by the Basic test above; in general we don't Import test updates since they're covered elsewhere)
| armClient := meta.(*ArmClient) | ||
| ctx := armClient.StopContext | ||
|
|
||
| id := strings.Split(d.Id(), "/") |
There was a problem hiding this comment.
there's a potential crash in these few lines if the segments aren't correct - as such we probably want to add below this:
if len(id) != 3 {
return fmt.Errorf("ID was not in the expected format - expected `{name}/{resourceGroup}/{storageAccountName}` got %q")
}
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
ghost
locked and limited conversation to collaborators
This PR allows quota to be updated. Import is now supported. General cleanup has also been done with moving the validation functions to their respective validation and validation test files.