Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examples of using Remote-Exec Provisioners for Windows and Linux #1665

Merged
merged 12 commits into from
Jul 30, 2018

Conversation

tombuildsstuff
Copy link
Contributor

@tombuildsstuff tombuildsstuff commented Jul 27, 2018

This PR adds an example of using a remote-exec provisioner via both WinRM (Windows) and SSH (Linux).

During building this I've noticed some inconsistencies in the VM Resource (validation) and Documentation - which I've taken the liberty of fixing.

I've also structured this such that we can move the other VM Examples within the virtual-machine folder (albeit as a follow up PR)

@tombuildsstuff tombuildsstuff requested a review from a team July 27, 2018 18:42
@tombuildsstuff tombuildsstuff changed the title [WIP] Examples of using Remote-Exec Provisioners for Windows and Linux [Examples of using Remote-Exec Provisioners for Windows and Linux Jul 27, 2018
@tombuildsstuff tombuildsstuff changed the title [Examples of using Remote-Exec Provisioners for Windows and Linux Examples of using Remote-Exec Provisioners for Windows and Linux Jul 27, 2018
Copy link
Collaborator

@WodansSon WodansSon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Tom, this mostly LGTM I just had a couple of questions for you inline.

location = "${azurerm_resource_group.main.location}"
resource_group_name = "${azurerm_resource_group.main.name}"
network_interface_ids = ["${azurerm_network_interface.main.id}"]
vm_size = "Standard_DS1_v2"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we use the Standard_DS2_v2 size here?

location = "${azurerm_resource_group.main.location}"
resource_group_name = "${azurerm_resource_group.main.name}"
network_interface_ids = ["${azurerm_network_interface.main.id}"]
vm_size = "Standard_DS1_v2"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same question here about vm size.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as above - this'll become Standard_F2

location = "${azurerm_resource_group.main.location}"
resource_group_name = "${azurerm_resource_group.main.name}"
network_interface_ids = ["${azurerm_network_interface.main.id}"]
vm_size = "Standard_DS1_v2"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same question as above vm size.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as above - this'll become Standard_F2

@@ -0,0 +1,15 @@
resource "azurerm_storage_account" "main" {
name = "${var.prefix}stor"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this supposed to be store not stor?

Copy link
Contributor Author

@tombuildsstuff tombuildsstuff Jul 29, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nope, unfortunately the length of the storage account name is limited to 15 chars, so every character matters :(

@tombuildsstuff tombuildsstuff merged commit d88d774 into master Jul 30, 2018
@tombuildsstuff tombuildsstuff deleted the provisioning-examples branch July 30, 2018 07:28
tombuildsstuff added a commit that referenced this pull request Jul 30, 2018
* Adding an example of using a remote-exec provisioner on linux

* Adding an example of using WinRM to run commands on a machine

* Adding an example of a VM with Unmanaged Disks

* Example of provisioning a Managed Disks VM from a Custom Image (ported from the VM Docs)

* Example of provisioning a Basic VM with Managed Disks

* Correctly documenting the delete methods

* Adding an example of attaching data disks to a vm

* Fixing the readme

* Updating the VM Docs to be clearer

* Fixing a bug in the attach disks demo

* additional validation for the vm resource

* Switching over to Standard_F2's for the examples
@ghost
Copy link

ghost commented Mar 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants