Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update VMSS docs to include ip_forwarding (fixes #1709) #1713

Merged
merged 2 commits into from
Aug 3, 2018
Merged

update VMSS docs to include ip_forwarding (fixes #1709) #1713

merged 2 commits into from
Aug 3, 2018

Conversation

katbyte
Copy link
Collaborator

@katbyte katbyte commented Aug 2, 2018 •
edited
Loading

fixes #1709

@katbyte katbyte added documentation service/vmss Virtual Machine Scale Sets labels Aug 2, 2018
@katbyte katbyte added this to the 1.12.0 milestone Aug 2, 2018
@katbyte katbyte requested a review from a team August 2, 2018 19:21
bflad
bflad approved these changes Aug 2, 2018
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! -- one quick question: should we also include that it defaults to false?

metacpp
metacpp approved these changes Aug 2, 2018
View reviewed changes
Copy link
Contributor

@metacpp metacpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@metacpp metacpp assigned metacpp and unassigned metacpp Aug 3, 2018
@tombuildsstuff
Copy link
Contributor

@bflad

should we also include that it defaults to false?

Yes we should - will push a commit to fix 👍

@tombuildsstuff tombuildsstuff merged commit 6e4266c into master Aug 3, 2018
@tombuildsstuff tombuildsstuff deleted the d-vmss-docs branch August 3, 2018 07:42
@ghost
Copy link

ghost commented Mar 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

@metacpp metacpp metacpp approved these changes

Assignees
No one assigned
Labels
documentation service/vmss Virtual Machine Scale Sets
Projects
None yet
Milestone
v1.12.0
Development

Successfully merging this pull request may close these issues.

ip_forwarding property for azurerm_virtual_machine_scale_set is not documented in terraform.io
4 participants
@katbyte @tombuildsstuff @bflad @metacpp