Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Authentication: making the client registration consistent #1845

Merged
merged 1 commit into from
Aug 30, 2018

Conversation

tombuildsstuff
Copy link
Contributor

This is a requirement for #1746 and the branch proxy-support - and is being made out-of-band to get this in ASAP to avoid extra conflicts (since this is a commonly touched file)

@tombuildsstuff tombuildsstuff added this to the 1.14.0 milestone Aug 30, 2018
@tombuildsstuff tombuildsstuff requested a review from a team August 30, 2018 14:44
@ghost ghost added the size/L label Aug 30, 2018
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tombuildsstuff
Copy link
Contributor Author

Given this affects every resource in the provider - we're going to handle the tests for this via the nightly run. A cursory test of a Resource Group test passes:

$ acctests azurerm TestAccAzureRMResourceGroup_basic
=== RUN   TestAccAzureRMResourceGroup_basic
--- PASS: TestAccAzureRMResourceGroup_basic (64.35s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm	64.705s

@tombuildsstuff tombuildsstuff merged commit 346fa81 into master Aug 30, 2018
@tombuildsstuff tombuildsstuff deleted the clients branch August 30, 2018 14:57
tombuildsstuff added a commit that referenced this pull request Aug 30, 2018
torresdal pushed a commit to torresdal/terraform-provider-azurerm that referenced this pull request Aug 31, 2018
torresdal pushed a commit to torresdal/terraform-provider-azurerm that referenced this pull request Aug 31, 2018
jbcom pushed a commit to platonic-io/terraform-provider-azurerm that referenced this pull request Sep 27, 2018
* timcurless/timcurless:
  Fixing issues with aadProfile server_app_secret always causing a new cluster
  Adding documentation updates
  Updating to include hashicorp#1845
  Authentication: registering all clients consistently (hashicorp#1845)
  Updating to include hashicorp#1843
  r/Logic App: ensuring parameters are strings prior to setting (hashicorp#1843)
  Updating to include hashicorp#1821
  linux_profile should be optional to align with API spec (hashicorp#1821)
  Updating to include hashicorp#1816
  Storage: Import Support (hashicorp#1816)
  Updating to include hashicorp#1835
  Allow azurerm_function_app to use upper case names in consumption plan (hashicorp#1835)
  formatting
@ghost
Copy link

ghost commented Mar 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants