Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update resource_arm_logic_app_trigger_http_request.go #1918

Merged
merged 2 commits into from
Sep 13, 2018

Conversation

alastairtree
Copy link
Contributor

@ghost ghost added the size/XS label Sep 12, 2018
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @alastairtree,

Thank you for this fix! It LGTM, however could we get an acceptance test to verify it works?

I would suggest taking the existing test config:

func testAccAzureRMLogicAppTriggerHttpRequest_relativePath(rInt int, location string) string {

and updating the terraform to have the new characters in it (or parameterize the relative path and create a new test)

@katbyte katbyte added this to the 1.15.0 milestone Sep 12, 2018
@ghost ghost added the size/XS label Sep 13, 2018
@alastairtree
Copy link
Contributor Author

I have added a param into the existing test. Full disclosure though - I edited this without testing it myself as I am not a go developer, just capable of tweaking a dodgey regex - so worth a little scrutiny please!

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thats what the tests are for 😄 and the tests all pass!

Thank you for the quick updates, LGTM 💯

@katbyte
Copy link
Collaborator

katbyte commented Sep 13, 2018

tests pass:
screen shot 2018-09-13 at 08 51 41

@katbyte katbyte merged commit 060d265 into hashicorp:master Sep 13, 2018
katbyte added a commit that referenced this pull request Sep 13, 2018
@alastairtree alastairtree deleted the patch-1 branch September 13, 2018 16:18
@ghost
Copy link

ghost commented Mar 6, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants