-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Resource: azurerm_security_center_contact #2045
Merged
Merged
Changes from 9 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
f31eaa0
added new resource azurerm_securitycenter_subscription_pricing
katbyte 05d7c54
Added docs
katbyte 3d94cd9
added new resource azurerm_securitycenter_contact
katbyte 4e33d2f
Added docs
katbyte 64dfcad
fix small typo in docs
katbyte 1ee95b2
Address PR #2043 comments
katbyte 3eab585
Merge branch 'r-security-pricing' into r-security-contact
katbyte 30f52c5
Address PR #2045 comments
katbyte 61d3be3
Added checkDestroy function
katbyte 53b08d2
Address more PR #2045 comments
katbyte File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,149 @@ | ||
package azurerm | ||
|
||
import ( | ||
"fmt" | ||
"github.com/Azure/azure-sdk-for-go/services/preview/security/mgmt/2017-08-01-preview/security" | ||
"github.com/hashicorp/terraform/helper/schema" | ||
"github.com/hashicorp/terraform/helper/validation" | ||
"github.com/terraform-providers/terraform-provider-azurerm/azurerm/utils" | ||
"log" | ||
) | ||
|
||
//seems you can only set one contact: | ||
// Invalid security contact name was provided - only 'defaultX' is allowed where X is an index | ||
// Invalid security contact name 'default0' was provided. Expected 'default1' | ||
// Message="Invalid security contact name 'default2' was provided. Expected 'default1'" | ||
const resourceArmSecurityCenterContactName = "default1" | ||
|
||
func resourceArmSecurityCenterContact() *schema.Resource { | ||
return &schema.Resource{ | ||
Create: resourceArmSecurityCenterContactCreateUpdate, | ||
Read: resourceArmSecurityCenterContactRead, | ||
Update: resourceArmSecurityCenterContactCreateUpdate, | ||
Delete: resourceArmSecurityCenterContactDelete, | ||
|
||
Importer: &schema.ResourceImporter{ | ||
State: schema.ImportStatePassthrough, | ||
}, | ||
|
||
Schema: map[string]*schema.Schema{ | ||
"email": { | ||
Type: schema.TypeString, | ||
Required: true, | ||
ValidateFunc: validation.NoZeroValues, | ||
}, | ||
|
||
"phone": { | ||
Type: schema.TypeString, | ||
Required: true, | ||
ValidateFunc: validation.NoZeroValues, | ||
}, | ||
|
||
"alert_notifications": { | ||
Type: schema.TypeBool, | ||
Required: true, | ||
}, | ||
|
||
"alerts_to_admins": { | ||
Type: schema.TypeBool, | ||
Required: true, | ||
}, | ||
}, | ||
} | ||
} | ||
|
||
func resourceArmSecurityCenterContactCreateUpdate(d *schema.ResourceData, meta interface{}) error { | ||
client := meta.(*ArmClient).securityCenterContactsClient | ||
ctx := meta.(*ArmClient).StopContext | ||
|
||
name := resourceArmSecurityCenterContactName | ||
|
||
contact := security.Contact{ | ||
ContactProperties: &security.ContactProperties{ | ||
Email: utils.String(d.Get("email").(string)), | ||
Phone: utils.String(d.Get("phone").(string)), | ||
}, | ||
} | ||
|
||
if alertNotifications := d.Get("alert_notifications").(bool); alertNotifications { | ||
contact.AlertNotifications = security.On | ||
} else { | ||
contact.AlertNotifications = security.Off | ||
} | ||
|
||
if alertNotifications := d.Get("alerts_to_admins").(bool); alertNotifications { | ||
contact.AlertsToAdmins = security.AlertsToAdminsOn | ||
} else { | ||
contact.AlertsToAdmins = security.AlertsToAdminsOff | ||
} | ||
|
||
if d.IsNewResource() { | ||
_, err := client.Create(ctx, name, contact) | ||
if err != nil { | ||
return fmt.Errorf("Error creating Security Center Contact: %+v", err) | ||
} | ||
|
||
resp, err := client.Get(ctx, name) | ||
if err != nil { | ||
return fmt.Errorf("Error reading Security Center Contact: %+v", err) | ||
} | ||
if resp.ID == nil { | ||
return fmt.Errorf("Security Center Contact ID is nil") | ||
} | ||
|
||
d.SetId(*resp.ID) | ||
} else { | ||
_, err := client.Update(ctx, name, contact) | ||
if err != nil { | ||
return fmt.Errorf("Error updating Security Center Contact: %+v", err) | ||
} | ||
} | ||
|
||
return resourceArmSecurityCenterContactRead(d, meta) | ||
} | ||
|
||
func resourceArmSecurityCenterContactRead(d *schema.ResourceData, meta interface{}) error { | ||
client := meta.(*ArmClient).securityCenterContactsClient | ||
ctx := meta.(*ArmClient).StopContext | ||
|
||
name := resourceArmSecurityCenterContactName | ||
|
||
resp, err := client.Get(ctx, name) | ||
if err != nil { | ||
if utils.ResponseWasNotFound(resp.Response) { | ||
log.Printf("[DEBUG] Security Center Subscription Contact was not found: %v", err) | ||
d.SetId("") | ||
return nil | ||
} | ||
|
||
return fmt.Errorf("Error reading Security Center Contact: %+v", err) | ||
} | ||
|
||
if properties := resp.ContactProperties; properties != nil { | ||
d.Set("email", properties.Email) | ||
d.Set("phone", properties.Phone) | ||
d.Set("alert_notifications", properties.AlertNotifications == security.On) | ||
d.Set("alerts_to_admins", properties.AlertsToAdmins == security.AlertsToAdminsOn) | ||
} | ||
|
||
return nil | ||
} | ||
|
||
func resourceArmSecurityCenterContactDelete(_ *schema.ResourceData, meta interface{}) error { | ||
client := meta.(*ArmClient).securityCenterContactsClient | ||
ctx := meta.(*ArmClient).StopContext | ||
|
||
name := resourceArmSecurityCenterContactName | ||
|
||
resp, err := client.Delete(ctx, name) | ||
if err != nil { | ||
if utils.ResponseWasNotFound(resp) { | ||
log.Printf("[DEBUG] Security Center Subscription Contact was not found: %v", err) | ||
return nil | ||
} | ||
|
||
return fmt.Errorf("Error deleting Security Center Contact: %+v", err) | ||
} | ||
|
||
return nil | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,130 @@ | ||
package azurerm | ||
|
||
import ( | ||
"fmt" | ||
"testing" | ||
|
||
"github.com/hashicorp/terraform/helper/resource" | ||
"github.com/hashicorp/terraform/terraform" | ||
"github.com/terraform-providers/terraform-provider-azurerm/azurerm/utils" | ||
) | ||
|
||
func TestAccAzureRMSecurityCenterContact_basic(t *testing.T) { | ||
resourceName := "azurerm_security_center_contact.test" | ||
|
||
resource.Test(t, resource.TestCase{ | ||
PreCheck: func() { testAccPreCheck(t) }, | ||
Providers: testAccProviders, | ||
CheckDestroy: testCheckAzureRMSecurityCenterContactDestroy, | ||
Steps: []resource.TestStep{ | ||
{ | ||
Config: testAccAzureRMSecurityCenterContact_template("[email protected]", "+1-555-555-5555", true, true), | ||
Check: resource.ComposeTestCheckFunc( | ||
testCheckAzureRMSecurityCenterContactExists(resourceName), | ||
resource.TestCheckResourceAttr(resourceName, "email", "[email protected]"), | ||
resource.TestCheckResourceAttr(resourceName, "phone", "+1-555-555-5555"), | ||
resource.TestCheckResourceAttr(resourceName, "alert_notifications", "true"), | ||
resource.TestCheckResourceAttr(resourceName, "alerts_to_admins", "true"), | ||
), | ||
}, | ||
{ | ||
ResourceName: resourceName, | ||
ImportState: true, | ||
ImportStateVerify: true, | ||
}, | ||
}, | ||
}) | ||
} | ||
|
||
func TestAccAzureRMSecurityCenterContact_update(t *testing.T) { | ||
resourceName := "azurerm_security_center_contact.test" | ||
|
||
resource.Test(t, resource.TestCase{ | ||
PreCheck: func() { testAccPreCheck(t) }, | ||
Providers: testAccProviders, | ||
CheckDestroy: testCheckAzureRMSecurityCenterContactDestroy, | ||
Steps: []resource.TestStep{ | ||
{ | ||
Config: testAccAzureRMSecurityCenterContact_template("[email protected]", "+1-555-555-5555", true, true), | ||
Check: resource.ComposeTestCheckFunc( | ||
testCheckAzureRMSecurityCenterContactExists(resourceName), | ||
resource.TestCheckResourceAttr(resourceName, "email", "[email protected]"), | ||
resource.TestCheckResourceAttr(resourceName, "phone", "+1-555-555-5555"), | ||
resource.TestCheckResourceAttr(resourceName, "alert_notifications", "true"), | ||
resource.TestCheckResourceAttr(resourceName, "alerts_to_admins", "true"), | ||
), | ||
}, | ||
{ | ||
Config: testAccAzureRMSecurityCenterContact_template("[email protected]", "+1-555-678-6789", false, false), | ||
Check: resource.ComposeTestCheckFunc( | ||
testCheckAzureRMSecurityCenterContactExists(resourceName), | ||
resource.TestCheckResourceAttr(resourceName, "email", "[email protected]"), | ||
resource.TestCheckResourceAttr(resourceName, "phone", "+1-555-678-6789"), | ||
resource.TestCheckResourceAttr(resourceName, "alert_notifications", "false"), | ||
resource.TestCheckResourceAttr(resourceName, "alerts_to_admins", "false"), | ||
), | ||
}, | ||
{ | ||
ResourceName: resourceName, | ||
ImportState: true, | ||
ImportStateVerify: true, | ||
}, | ||
}, | ||
}) | ||
} | ||
|
||
func testCheckAzureRMSecurityCenterContactExists(name string) resource.TestCheckFunc { | ||
return func(s *terraform.State) error { | ||
client := testAccProvider.Meta().(*ArmClient).securityCenterContactsClient | ||
ctx := testAccProvider.Meta().(*ArmClient).StopContext | ||
|
||
rs, ok := s.RootModule().Resources[name] | ||
if !ok { | ||
return fmt.Errorf("Not found: %s", name) | ||
} | ||
|
||
contactName := rs.Primary.Attributes["securityContacts"] | ||
|
||
resp, err := client.Get(ctx, contactName) | ||
if err != nil { | ||
if utils.ResponseWasNotFound(resp.Response) { | ||
return fmt.Errorf("Security Center Subscription Contact %q was not found: %+v", contactName, err) | ||
} | ||
|
||
return fmt.Errorf("Bad: GetContact: %+v", err) | ||
} | ||
|
||
return nil | ||
} | ||
} | ||
|
||
func testCheckAzureRMSecurityCenterContactDestroy(s *terraform.State) error { | ||
client := testAccProvider.Meta().(*ArmClient).securityCenterContactsClient | ||
ctx := testAccProvider.Meta().(*ArmClient).StopContext | ||
for _, res := range s.RootModule().Resources { | ||
if res.Type != "azurerm_security_center_contact" { | ||
continue | ||
} | ||
resp, err := client.Get(ctx, resourceArmSecurityCenterContactName) | ||
if err != nil { | ||
if utils.ResponseWasNotFound(resp.Response) { | ||
return nil | ||
} | ||
return err | ||
} | ||
return fmt.Errorf("security center contact still exists") | ||
} | ||
return nil | ||
} | ||
|
||
func testAccAzureRMSecurityCenterContact_template(email, phone string, notifications, adminAlerts bool) string { | ||
return fmt.Sprintf(` | ||
resource "azurerm_security_center_contact" "test" { | ||
email = "%s" | ||
phone = "%s" | ||
|
||
alert_notifications = %t | ||
alerts_to_admins = %t | ||
} | ||
`, email, phone, notifications, adminAlerts) | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor can we ditch
resourceArm
at the start of this