Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Application Gateway: Refactoring #2054

Merged
merged 43 commits into from
Nov 12, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
43 commits
Select commit Hold shift + click to select a range
46a74b2
Refactoring: removing deprecated methods
tombuildsstuff Oct 10, 2018
5368369
Refactoring: sku -> list
tombuildsstuff Oct 10, 2018
fc0cd0e
Refactoring: removing the separate ID parsing method
tombuildsstuff Oct 10, 2018
be80b30
Refactoring: consistency in the Create/expands
tombuildsstuff Oct 10, 2018
722c264
Refactoring: removing the default array sizing/crash points
tombuildsstuff Oct 10, 2018
aab6d51
Refactoring: temporarily splitting methods out to keep track
tombuildsstuff Oct 10, 2018
d25b588
Refactoring: sorting the sets
tombuildsstuff Oct 10, 2018
31b9676
Refactor: `authentication_certificates` is a List not a Set
tombuildsstuff Oct 10, 2018
f94e9a8
Refactor: Backend Address Pools - ensuring always set
tombuildsstuff Oct 10, 2018
433578a
Refactor: using the right error
tombuildsstuff Oct 10, 2018
47c783a
Refactoring: `backend_http_settings` - removing crashes
tombuildsstuff Oct 10, 2018
a0e1179
Refactoring: `disabled_ssl_protocols`
tombuildsstuff Oct 10, 2018
9388ffe
Refactor: removing crashes from `http_listener`
tombuildsstuff Oct 10, 2018
2a5f9f0
Refactor: removing crashes from `gateway_ip_configuration`
tombuildsstuff Oct 10, 2018
6ddb47c
Refactoring: removing crashes from `frontend_port`
tombuildsstuff Oct 10, 2018
76b83d5
Refactor: removing crashes from `frontend_ip_configuration`
tombuildsstuff Oct 10, 2018
c2ea8d7
Refactor: removing crashes from `probe`
tombuildsstuff Oct 10, 2018
7cd5b5d
Refactor: removing crashes from `request_routing_rule`
tombuildsstuff Oct 10, 2018
fb5917c
Refactor: removing a crash from `sku`
tombuildsstuff Oct 10, 2018
77a7067
Refactor: setting `ssl_certificate` as a List rather than a Set to ma…
tombuildsstuff Oct 10, 2018
2428962
Refactoring: removing crash points in `url_path_map`
tombuildsstuff Oct 10, 2018
04ed152
Refactor: `waf_configuration` - removing crash points
tombuildsstuff Oct 10, 2018
76067b2
Refactor: `waf_configuration` - Set -> List
tombuildsstuff Oct 10, 2018
2329830
Sorting the schema by Required -> Optional
tombuildsstuff Oct 10, 2018
529dcb5
Rewriting the documentation for Application Gateway
tombuildsstuff Oct 10, 2018
55bb15e
Docs: adding back in the example
tombuildsstuff Oct 10, 2018
40d2e9e
Bugfix: setting Probe as a list
tombuildsstuff Oct 11, 2018
c08c64e
Ensuring we dereference the waf_configuration
tombuildsstuff Nov 1, 2018
94412b8
Required -> Optional -> Computed
tombuildsstuff Nov 1, 2018
a39f5b2
Docs fixes
tombuildsstuff Nov 1, 2018
02b93f5
refactoring: Switching to parsing the ID's using parseAzureResourceID
tombuildsstuff Nov 2, 2018
77aee63
refactoring: removing the `name` field
tombuildsstuff Nov 2, 2018
0465c19
adding in missing validation
tombuildsstuff Nov 2, 2018
09aab00
bugfix: setting the id rather than the parsed id
tombuildsstuff Nov 2, 2018
fea5b1d
making the `match` block computed
tombuildsstuff Nov 2, 2018
e2752bc
loading the certificate data/password from the input config
tombuildsstuff Nov 3, 2018
e5b5a3b
refactor: combining the common sections of the tests
tombuildsstuff Nov 5, 2018
41ffcb0
refactor: removing comments from the tests
tombuildsstuff Nov 5, 2018
c7e19bb
refactor: base64-encoding the existing value
tombuildsstuff Nov 9, 2018
fd77ab3
linting fixes
tombuildsstuff Nov 9, 2018
3f93705
Rewriting the app gateway tests
tombuildsstuff Nov 9, 2018
6df033c
hostname -> host_name
tombuildsstuff Nov 12, 2018
f1efeeb
Switching to use the right certificate
tombuildsstuff Nov 12, 2018
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions azurerm/provider.go
Original file line number Diff line number Diff line change
Expand Up @@ -400,6 +400,15 @@ func userDataStateFunc(v interface{}) string {
}
}

func base64EncodedStateFunc(v interface{}) string {
switch s := v.(type) {
case string:
return base64Encode(s)
default:
return ""
}
}

// base64Encode encodes data if the input isn't already encoded using
// base64.StdEncoding.EncodeToString. If the input is already base64 encoded,
// return the original input unchanged.
Expand Down
Loading