Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #1722 - function app's setting read #2111

Merged
merged 3 commits into from
Oct 20, 2018
Merged

Fixes #1722 - function app's setting read #2111

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
44927a9
Merge remote-tracking branch 'remote/master'
Oct 18, 2018
d82e5ad
Adds logic to return nil if none appsettings
DexterPOSH Oct 18, 2018
fae6111
Clears the id
DexterPOSH Oct 20, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions azurerm/resource_arm_function_app.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -402,6 +402,11 @@ func resourceArmFunctionAppRead(d *schema.ResourceData, meta interface{}) error

appSettingsResp, err := client.ListApplicationSettings(ctx, resGroup, name)
if err != nil {
if utils.ResponseWasNotFound(appSettingsResp.Response) {
log.Printf("[DEBUG] Application Settings of Function App %q (resource group %q) were not found", name, resGroup)
d.SetId("")
return nil
DexterPOSH marked this conversation as resolved.
Show resolved Hide resolved
}
return fmt.Errorf("Error making Read request on AzureRM Function App AppSettings %q: %+v", name, err)
}

Expand Down