Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/kubernetes_cluster: support for rbac without azuread / exporting the admin profile #2495

Merged
merged 4 commits into from
Dec 12, 2018

Conversation

tombuildsstuff
Copy link
Contributor

This PR adds support for Role Based Access Control without Azure Active Directory to both the azurerm_kubernetes_cluster Resource and Data Source; and also exports the Kubernetes Admin Profile if Role Based Access Control with AzureAD is enabled on the cluster to both the Resource & Data Source too.

Fixes #2345
Fixes #2421
Supersedes #2347

@tombuildsstuff
Copy link
Contributor Author

Resource Tests pass for this (excluding the version of K8s used in the test being unavailable, which I've pushed a commit to fix:

screenshot 2018-12-12 at 16 06 41

Data Source tests pass, excluding a known test failure which we'll look at separately:

screenshot 2018-12-12 at 16 07 30

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tombuildsstuff tombuildsstuff merged commit b21a4fe into master Dec 12, 2018
@tombuildsstuff tombuildsstuff deleted the f/kubernetes-rbac branch December 12, 2018 16:51
tombuildsstuff added a commit that referenced this pull request Dec 12, 2018
@@ -169,6 +169,8 @@ A `role_based_access_control` block supports the following:

* `azure_active_directory` - (Required) An `azure_active_directory` block. Changing this forces a new resource to be created.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this still required? Or can be skipped if one wants just RBAC?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good spot - this is now optional

@ghost
Copy link

ghost commented Mar 5, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants