Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for handling the dns_prefix property of an AKS cluster #2611

Merged
merged 4 commits into from
Jan 8, 2019

Commits on Jan 7, 2019

  1. Force recreate on DNS prefix change of AKS cluster

    If you try to change the DNS prefix with the configuration before this
    change, `terraform apply` will fail with a message to this effect.
    tomasaschan committed Jan 7, 2019
    Configuration menu
    Copy the full SHA
    a6051d9 View commit details
    Browse the repository at this point in the history
  2. Validate DNS prefix

    This validation is not done in the CLI, so creating a cluster with a DNS
    prefix that does not fulfill these requirements will not fail. However,
    in some cases such a cluster will be badly broken; for example, if the
    specified DNS prefix has subdomain parts (e.g. foo.bar.baz), certificate
    validation will fail when communicating with the cluster, resulting in
    broken behavior for commands such as kubectl logs.
    
    Because of the seriously broken state a cluster can end up in, and since
    the cluster will have to be completely recreated in order to change the
    DNS prefix, I think it's worthwhile to implement this validation even
    before the CLI has been patched to include it.
    
    The source for the validation rules (and error message) is the client-
    side validation error message in the Azure Portal, where validation is
    already implemented.
    tomasaschan committed Jan 7, 2019
    Configuration menu
    Copy the full SHA
    d16b533 View commit details
    Browse the repository at this point in the history
  3. Apply gofmt

    tomasaschan committed Jan 7, 2019
    Configuration menu
    Copy the full SHA
    15f7fc4 View commit details
    Browse the repository at this point in the history

Commits on Jan 8, 2019

  1. refactor regex

    katbyte committed Jan 8, 2019
    Configuration menu
    Copy the full SHA
    91742e1 View commit details
    Browse the repository at this point in the history