Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

data.azurerm_network_interface: add missing property ip_configuration.private_ip_address_version #2646

Merged
merged 1 commit into from
Jan 11, 2019
Merged

data.azurerm_network_interface: add missing property ip_configuration.private_ip_address_version #2646

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions azurerm/data_source_network_interface.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,12 @@ func dataSourceArmNetworkInterface() *schema.Resource {
Computed: true,
},

"private_ip_address_version": {
Type: schema.TypeString,
Computed: true,
},

//TODO: should this be renamed to private_ip_address_allocation_method or private_ip_allocation_method ?
"private_ip_address_allocation": {
Type: schema.TypeString,
Computed: true,
Expand Down
2 changes: 1 addition & 1 deletion azurerm/resource_arm_network_interface.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,6 @@ func resourceArmNetworkInterface() *schema.Resource {
Optional: true,
},

//TODO: should this be renamed to private_ip_address_allocation_method or private_ip_allocation_method ?
"private_ip_address_version": {
Type: schema.TypeString,
Optional: true,
Expand All @@ -93,6 +92,7 @@ func resourceArmNetworkInterface() *schema.Resource {
}, false),
},

//TODO: should this be renamed to private_ip_address_allocation_method or private_ip_allocation_method ?
"private_ip_address_allocation": {
Type: schema.TypeString,
Required: true,
Expand Down