Limits conforming to Azure docs: https://docs.microsoft.com/en-us/azu…

[georgespatton]

This should fix #2136 as well as #2624 to follow the Azure documentation here: https://docs.microsoft.com/en-us/azure/virtual-machine-scale-sets/overview

Fixes #2624

[katbyte]

Hi @georgespatton,

Thanks for opening this PR. The change LGTM however could we add a test with the capacity block and the properties at 0 is one step and something > 40 in the next?

Thanks!

[georgespatton]

@katbyte I added a test case, let me know what you think.

[tombuildsstuff]

hey @georgespatton

Thanks for pushing those changes :)

As a part of the v1.22 release we're renaming the azurerm_autoscale_setting resource to azurerm_monitor_autoscale_setting - as such this change will need to be made in both places. So that we can get this merged and released as a part of the v1.22 release - I'm going to push a commit which also makes this change to that resource (and updates the documentation), I hope you don't mind!

Thanks!

[georgespatton]

Sounds great, thank you!

[tombuildsstuff]

@georgespatton apologies, I don't entirely understand how but I appear to have broken this PR upon pushing the updates to your fork. I hope you don't mind but I'm going to open another PR which includes these commits - you'll still get the credits/attribution for this (since these include your commits) - and this should go out as a part of v1.22 - apologies either way!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!