Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Application Gateway] Add WAF properties for request body checking #3093

Merged
merged 1 commit into from
Mar 21, 2019

Conversation

Lucretius
Copy link
Contributor

Resolves #3088 by including request_body_check and max_request_body_size_kb properties. WAF test within the application gateway test suite has been updated to verify the new configuration values. Documentation has been updated to align with the WAF documentation.

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Lucretius, thank you for the PR!

This LGTM however I an curious as to where you got the default for max_request_body_size_kb? does the portal default to 128?

@Lucretius
Copy link
Contributor Author

This LGTM however I an curious as to where you got the default for max_request_body_size_kb? does the portal default to 128?

The WAF documentation I linked in the PR is where I got the default value from:

The maximum request body size field is specified in KBs and controls overall request size limit excluding any file uploads. This field can range from 1-KB minimum to 128-KB maximum value. The default value for request body size is 128 KB.

@katbyte
Copy link
Collaborator

katbyte commented Mar 21, 2019

Awesome! thanks

@katbyte katbyte merged commit a379239 into hashicorp:master Mar 21, 2019
katbyte added a commit that referenced this pull request Mar 21, 2019
@ghost
Copy link

ghost commented Apr 3, 2019

This has been released in version 1.24.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
	version = "~> 1.24.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Apr 20, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WAF_V2 on creation is not setting Max request body size
2 participants