Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade azure-sdk-for-go to v29.0.0 #3335

Merged
merged 7 commits into from
May 10, 2019
Merged

Upgrade azure-sdk-for-go to v29.0.0 #3335

merged 7 commits into from
May 10, 2019

Conversation

katbyte
Copy link
Collaborator

@katbyte katbyte commented Apr 29, 2019

No description provided.

@katbyte katbyte added dependencies upstream/microsoft Indicates that there's an upstream issue blocking this issue/PR labels Apr 29, 2019
@katbyte katbyte added this to the v1.28.0 milestone Apr 29, 2019
@ghost ghost added the size/XXL label Apr 29, 2019
@katbyte
Copy link
Collaborator Author

katbyte commented May 1, 2019

Blocked on: Azure/azure-sdk-for-go#4705

@katbyte katbyte modified the milestones: v1.28.0, Blocked May 1, 2019
@katbyte katbyte mentioned this pull request May 1, 2019
7 tasks
@katbyte katbyte changed the title Upgrade azure-sdk-for-go to v28.0.0 Upgrade azure-sdk-for-go to v29.0.0 May 7, 2019
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@katbyte katbyte merged commit e52070c into master May 10, 2019
@katbyte katbyte deleted the sdk/v28.0.0 branch May 10, 2019 21:10
katbyte added a commit that referenced this pull request May 10, 2019
@ghost
Copy link

ghost commented May 17, 2019

This has been released in version 1.28.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
	version = "~> 1.28.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Jun 10, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Jun 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants