Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Application gateway: Autoscale configuration #3353

Merged
merged 13 commits into from
May 7, 2019

Conversation

timja
Copy link
Contributor

@timja timja commented May 1, 2019

Fixes #2603

@ghost ghost added the size/L label May 1, 2019
@timja timja force-pushed the feature/ag-autoscale-configuration branch from f44bbab to 7404d36 Compare May 1, 2019 13:00
@ghost ghost added size/XL documentation and removed size/L labels May 2, 2019
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @timja. Thanks for submitting this PR! Things look great but we just need some additional validation/testing. Let me know if you have any questions.

azurerm/resource_arm_application_gateway.go Outdated Show resolved Hide resolved
azurerm/resource_arm_application_gateway.go Show resolved Hide resolved
azurerm/resource_arm_application_gateway.go Outdated Show resolved Hide resolved
@timja
Copy link
Contributor Author

timja commented May 7, 2019

All comments should be addressed

@ghost ghost removed the waiting-response label May 7, 2019
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @timja, apologies for missing this on my initial review but we hit quite a few panics after rerunning the application gateway tests. Do you mind taking a look at my comment and seeing if that or something similar makes sense to include?

=== RUN   TestAccAzureRMApplicationGateway_authCertificate
=== PAUSE TestAccAzureRMApplicationGateway_authCertificate
=== CONT  TestAccAzureRMApplicationGateway_authCertificate

------- Stderr: -------
panic: runtime error: index out of range

goroutine 400 [running]:
github.com/terraform-providers/terraform-provider-azurerm/azurerm.expandAutoscaleConfiguration(0xc0005f28c0, 0xc000a36c60)
	/opt/teamcity-agent/work/458e5e4800bd94f6/src/github.com/terraform-providers/terraform-provider-azurerm/azurerm/resource_arm_application_gateway.go:2311 +0x249
github.com/terraform-providers/terraform-provider-azurerm/azurerm.resourceArmApplicationGatewayCreateUpdate(0xc0005f28c0, 0x342c180, 0xc0005b6000, 0x2, 0x680a1a0)

azurerm/resource_arm_application_gateway.go Show resolved Hide resolved
timja added 2 commits May 7, 2019 20:55
…/terraform-provider-azurerm into feature/ag-autoscale-configuration
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And all tests pass now! Thanks for your efforts here @timja. Merging now

@mbfrahry mbfrahry merged commit f1b911b into hashicorp:master May 7, 2019
@timja timja deleted the feature/ag-autoscale-configuration branch May 8, 2019 06:06
@ghost
Copy link

ghost commented Jun 7, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Jun 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Application Gateway autoscaling
4 participants