-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
azurerm_kubernetes_cluster: Add support for virtual machine scale set node pool #3422
Conversation
…and data source `azurerm_kubernetes_cluster`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @dominik-lekse,
Thanks for the PR, i've left a few comments inline but overall this is looking good.
Co-Authored-By: kt <[email protected]>
Hi @katbyte, thanks for the quick review. All suggestions confirmed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @dominik-lekse! this LGTM now 🚀
I'm really sorry @dominik-lekse but i was looking at the wrong test results when I merged this 😞 It breaks all the other tests with:
because the api automatically sets it to |
Hi @katbyte, apologies for being not strict enough on the test execution, I should have run at least one of the existing acceptance tests. My assumption was that the With the default value, we have also covered upgrading of tf states produces by previous provider versions, right? Since the commit is in the original branch, I will reopen the pull request.
|
This has been released in version 1.28.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 1.28.0"
}
# ... other configuration ... |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
This pull request adds support for virtual machine scale set node pools in the resource and data source
azurerm_kubernetes_cluster
.TestAccAzureRMKubernetesCluster_virtualMachineScaleSets
requires the resource provider featuresMultiAgentpoolPreview
andVMSSPreview
. I assume these features are registered before the test is executed. Refer to https://docs.microsoft.com/en-us/azure/aks/use-multiple-node-pools.Tests
New or Affected Resource(s)
azurerm_kubernetes_cluster
References