Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed unnecessary force deletes from Service Fabric #3668

Closed
wants to merge 4 commits into from

Conversation

steve-hawkins
Copy link
Contributor

removed the force delete from Service Fabric cluster node types and diagnostic storage account

added more testing around the ability to update / delete Service Fabric cluster configuration

@ghost ghost added the size/XL label Jun 14, 2019
@steve-hawkins
Copy link
Contributor Author

please let me know if there is anything else I can do to get this merged into the 1.31.0 release

@ghost ghost added size/XS and removed size/XL labels Jun 21, 2019
@katbyte
Copy link
Collaborator

katbyte commented Jun 24, 2019

Hi @steve-hawkins,

It looks like there are no changed files or lines in this PR? 🤔

@steve-hawkins
Copy link
Contributor Author

@katbyte please close this PR as the changes are included in the following merged PR #3652

@ghost ghost removed the waiting-response label Jun 25, 2019
@katbyte
Copy link
Collaborator

katbyte commented Jun 26, 2019

Thanks for confirming @steve-hawkins! closing

@ghost
Copy link

ghost commented Jun 28, 2019

This has been released in version 1.31.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.31.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Jul 27, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Jul 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants