Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Resource: azurerm_storage_management_policy #3819

Merged
merged 42 commits into from
Oct 2, 2019

Conversation

stuartleeks
Copy link
Contributor

@stuartleeks stuartleeks commented Jul 10, 2019

Add support for Storage Management Policies to archive/delete blobs

Fixes #3316

@stuartleeks stuartleeks force-pushed the blob-storage-lifecycle branch 2 times, most recently from df7cbec to 5f6115a Compare July 10, 2019 08:44
@stuartleeks stuartleeks changed the title Add support for Storage Management Policies FEEDBACK WANTED: Add support for Storage Management Policies Jul 10, 2019
@tombuildsstuff tombuildsstuff self-assigned this Jul 16, 2019
@BenDutton
Copy link
Contributor

Looks like the issue has been fixed and released :)

@sgiacomel
Copy link

Any update on this?

@stuartleeks stuartleeks force-pushed the blob-storage-lifecycle branch 4 times, most recently from 8fe3ea8 to 1539a50 Compare September 2, 2019 15:41
@stuartleeks stuartleeks changed the title FEEDBACK WANTED: Add support for Storage Management Policies Add support for Storage Management Policies Sep 2, 2019
@stuartleeks stuartleeks marked this pull request as ready for review September 2, 2019 15:52
@stuartleeks stuartleeks force-pushed the blob-storage-lifecycle branch 2 times, most recently from 6d6600b to cd75159 Compare September 3, 2019 12:49
@stuartleeks
Copy link
Contributor Author

I've just rebased these changes to resolve a conflict in provider.go. Let me know if you're happy to merge or have any other feedback. Thanks :-)

@batizar
Copy link

batizar commented Sep 18, 2019

Any updates on this? Thanks.

@stuartleeks
Copy link
Contributor Author

@batizar I'm waiting on review to see if there are any other changes required for merging. When I spoke with @tombuildsstuff he was expecting to look at this next week

@batizar
Copy link

batizar commented Sep 24, 2019

Thanks @stuartleeks

Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @stuartleeks these changes look good but there are some areas where we could make improvements. The bulk of changes to make are just nil checks. Any time we are casting from an interface{} we should confirm that it's not nil. If it is nil and we try to cast it, Terraform crashes and then people could lose state so we need to limit it wherever we can. I called it out in a few places but just comb through and make sure that we're doing those checks everywhere. The other things I pointed out are just best practices we should consider adding to this PR.

azurerm/data_source_storage_management_policy_test.go Outdated Show resolved Hide resolved
azurerm/data_source_storage_management_policy_test.go Outdated Show resolved Hide resolved
azurerm/data_source_storage_management_policy_test.go Outdated Show resolved Hide resolved
azurerm/resource_arm_storage_management_policy.go Outdated Show resolved Hide resolved
azurerm/resource_arm_storage_management_policy.go Outdated Show resolved Hide resolved
website/docs/r/storage_management_policy.html.markdown Outdated Show resolved Hide resolved
website/docs/r/storage_management_policy.html.markdown Outdated Show resolved Hide resolved
azurerm/resource_arm_storage_management_policy.go Outdated Show resolved Hide resolved
website/docs/r/storage_management_policy.html.markdown Outdated Show resolved Hide resolved
website/docs/r/storage_management_policy.html.markdown Outdated Show resolved Hide resolved
@stuartleeks
Copy link
Contributor Author

@mbfrahry - thanks for your thorough review. I've been through your review comments and believe that I have now addressed them. I've also rebased to handle conflicts with other merged changes. Let me know if there are any further changes you would like to see before merging.

Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks for going through and addressing all my concerns @stuartleeks. These all look good and we're good to merge.

@mbfrahry mbfrahry changed the title Add support for Storage Management Policies New Resource: azurerm_storage_management_policy Oct 2, 2019
@mbfrahry mbfrahry merged commit 66a46ab into hashicorp:master Oct 2, 2019
@ghost
Copy link

ghost commented Mar 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for Azure Blob Storage Lifecycle
6 participants