Added new datasource for keyvault access policies #423
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,107 @@ | ||
| package azurerm | ||
|
|
||
| import ( | ||
| "strings" | ||
|
|
||
| "github.com/Azure/azure-sdk-for-go/arm/keyvault" | ||
| "github.com/hashicorp/terraform/helper/schema" | ||
| "github.com/hashicorp/terraform/helper/validation" | ||
| ) | ||
|
|
||
| func dataSourceArmKeyVaultAccessPolicy() *schema.Resource { | ||
| return &schema.Resource{ | ||
| Read: dataSourceArmKeyVaultAccessPolicyRead, | ||
| Schema: map[string]*schema.Schema{ | ||
| "name": { | ||
| Type: schema.TypeString, | ||
| Required: true, | ||
| ValidateFunc: validation.StringInSlice([]string{ | ||
| "Key Management", | ||
| "Secret Management", | ||
| "Certificate Management", | ||
| "Key & Secret Management", | ||
| "Key & Certificate Management", | ||
| "Secret & Certificate Management", | ||
| "Key, Secret, & Certificate Management", | ||
| }, false), | ||
| }, | ||
|
|
||
| // Computed | ||
| "certificate_permissions": { | ||
| Type: schema.TypeList, | ||
| Computed: true, | ||
| Elem: &schema.Schema{ | ||
| Type: schema.TypeString, | ||
| }, | ||
| }, | ||
| "key_permissions": { | ||
| Type: schema.TypeList, | ||
| Computed: true, | ||
| Elem: &schema.Schema{ | ||
| Type: schema.TypeString, | ||
| }, | ||
| }, | ||
| "secret_permissions": { | ||
| Type: schema.TypeList, | ||
| Computed: true, | ||
| Elem: &schema.Schema{ | ||
| Type: schema.TypeString, | ||
| }, | ||
| }, | ||
| }, | ||
| } | ||
| } | ||
|
|
||
| func dataSourceArmKeyVaultAccessPolicyRead(d *schema.ResourceData, meta interface{}) error { | ||
| name := d.Get("name").(string) | ||
| templateManagementPermissions := map[string][]string{ | ||
| "key": { | ||
| string(keyvault.KeyPermissionsGet), | ||
| string(keyvault.KeyPermissionsList), | ||
| string(keyvault.KeyPermissionsUpdate), | ||
| string(keyvault.KeyPermissionsCreate), | ||
| string(keyvault.KeyPermissionsImport), | ||
| string(keyvault.KeyPermissionsDelete), | ||
| string(keyvault.KeyPermissionsRecover), | ||
| string(keyvault.KeyPermissionsBackup), | ||
| string(keyvault.KeyPermissionsRestore), | ||
| }, | ||
| "secret": { | ||
| string(keyvault.SecretPermissionsGet), | ||
| string(keyvault.SecretPermissionsList), | ||
| string(keyvault.SecretPermissionsSet), | ||
| string(keyvault.SecretPermissionsDelete), | ||
| string(keyvault.SecretPermissionsRecover), | ||
| string(keyvault.SecretPermissionsBackup), | ||
| string(keyvault.SecretPermissionsRestore), | ||
| }, | ||
| "certificate": { | ||
| string(keyvault.Get), | ||
| string(keyvault.List), | ||
| string(keyvault.Update), | ||
| string(keyvault.Create), | ||
| string(keyvault.Import), | ||
| string(keyvault.Delete), | ||
| string(keyvault.Managecontacts), | ||
| string(keyvault.Manageissuers), | ||
| string(keyvault.Getissuers), | ||
| string(keyvault.Listissuers), | ||
| string(keyvault.Setissuers), | ||
| string(keyvault.Deleteissuers), | ||
| }, | ||
| } | ||
|
|
||
| d.SetId(name) | ||
|
|
||
| if strings.Contains(name, "Key") { | ||
| d.Set("key_permissions", templateManagementPermissions["key"]) | ||
| } | ||
| if strings.Contains(name, "Secret") { | ||
| d.Set("secret_permissions", templateManagementPermissions["secret"]) | ||
| } | ||
| if strings.Contains(name, "Certificate") { | ||
| d.Set("certificate_permissions", templateManagementPermissions["certificate"]) | ||
| } | ||
|
There was a problem hiding this comment. 🤔 do we need to set an empty list for each of these values if it's not present? |
||
|
|
||
| return nil | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,142 @@ | ||
| package azurerm | ||
|
|
||
| import ( | ||
| "fmt" | ||
| "testing" | ||
|
|
||
| "github.com/hashicorp/terraform/helper/resource" | ||
| ) | ||
|
|
||
| func TestAccDataSourceAzureRMKeyVaultAccessPolicy_key(t *testing.T) { | ||
| dataSourceName := "data.azurerm_key_vault_access_policy.test" | ||
| resource.Test(t, resource.TestCase{ | ||
| PreCheck: func() { testAccPreCheck(t) }, | ||
| Providers: testAccProviders, | ||
| Steps: []resource.TestStep{ | ||
| { | ||
| Config: testAccDataSourceKeyVaultAccessPolicy("Key Management"), | ||
| Check: resource.ComposeTestCheckFunc( | ||
| resource.TestCheckResourceAttr(dataSourceName, "key_permissions.#", "9"), | ||
| resource.TestCheckNoResourceAttr(dataSourceName, "secret_permissions"), | ||
| resource.TestCheckNoResourceAttr(dataSourceName, "certificate_permissions"), | ||
|
There was a problem hiding this comment. 🤔 should we be checking there's |
||
| ), | ||
| }, | ||
| }, | ||
| }) | ||
| } | ||
|
|
||
| func TestAccDataSourceAzureRMKeyVaultAccessPolicy_secret(t *testing.T) { | ||
| dataSourceName := "data.azurerm_key_vault_access_policy.test" | ||
| resource.Test(t, resource.TestCase{ | ||
| PreCheck: func() { testAccPreCheck(t) }, | ||
| Providers: testAccProviders, | ||
| Steps: []resource.TestStep{ | ||
| { | ||
| Config: testAccDataSourceKeyVaultAccessPolicy("Secret Management"), | ||
| Check: resource.ComposeTestCheckFunc( | ||
| resource.TestCheckNoResourceAttr(dataSourceName, "key_permissions"), | ||
| resource.TestCheckResourceAttr(dataSourceName, "secret_permissions.#", "7"), | ||
| resource.TestCheckNoResourceAttr(dataSourceName, "certificate_permissions"), | ||
| ), | ||
| }, | ||
| }, | ||
| }) | ||
| } | ||
|
|
||
| func TestAccDataSourceAzureRMKeyVaultAccessPolicy_certificate(t *testing.T) { | ||
| dataSourceName := "data.azurerm_key_vault_access_policy.test" | ||
| resource.Test(t, resource.TestCase{ | ||
| PreCheck: func() { testAccPreCheck(t) }, | ||
| Providers: testAccProviders, | ||
| Steps: []resource.TestStep{ | ||
| { | ||
| Config: testAccDataSourceKeyVaultAccessPolicy("Certificate Management"), | ||
| Check: resource.ComposeTestCheckFunc( | ||
| resource.TestCheckNoResourceAttr(dataSourceName, "key_permissions"), | ||
| resource.TestCheckNoResourceAttr(dataSourceName, "secret_permissions"), | ||
| resource.TestCheckResourceAttr(dataSourceName, "certificate_permissions.#", "12"), | ||
| ), | ||
| }, | ||
| }, | ||
| }) | ||
| } | ||
|
|
||
| func TestAccDataSourceAzureRMKeyVaultAccessPolicy_keySecret(t *testing.T) { | ||
| dataSourceName := "data.azurerm_key_vault_access_policy.test" | ||
| resource.Test(t, resource.TestCase{ | ||
| PreCheck: func() { testAccPreCheck(t) }, | ||
| Providers: testAccProviders, | ||
| Steps: []resource.TestStep{ | ||
| { | ||
| Config: testAccDataSourceKeyVaultAccessPolicy("Key & Secret Management"), | ||
| Check: resource.ComposeTestCheckFunc( | ||
| resource.TestCheckResourceAttr(dataSourceName, "key_permissions.#", "9"), | ||
| resource.TestCheckResourceAttr(dataSourceName, "secret_permissions.#", "7"), | ||
| resource.TestCheckNoResourceAttr(dataSourceName, "certificate_permissions"), | ||
| ), | ||
| }, | ||
| }, | ||
| }) | ||
| } | ||
|
|
||
| func TestAccDataSourceAzureRMKeyVaultAccessPolicy_keyCertificate(t *testing.T) { | ||
| dataSourceName := "data.azurerm_key_vault_access_policy.test" | ||
| resource.Test(t, resource.TestCase{ | ||
| PreCheck: func() { testAccPreCheck(t) }, | ||
| Providers: testAccProviders, | ||
| Steps: []resource.TestStep{ | ||
| { | ||
| Config: testAccDataSourceKeyVaultAccessPolicy("Key & Certificate Management"), | ||
| Check: resource.ComposeTestCheckFunc( | ||
| resource.TestCheckResourceAttr(dataSourceName, "key_permissions.#", "9"), | ||
| resource.TestCheckNoResourceAttr(dataSourceName, "secret_permissions"), | ||
| resource.TestCheckResourceAttr(dataSourceName, "certificate_permissions.#", "12"), | ||
| ), | ||
| }, | ||
| }, | ||
| }) | ||
| } | ||
|
|
||
| func TestAccDataSourceAzureRMKeyVaultAccessPolicy_secretCertificate(t *testing.T) { | ||
| dataSourceName := "data.azurerm_key_vault_access_policy.test" | ||
| resource.Test(t, resource.TestCase{ | ||
| PreCheck: func() { testAccPreCheck(t) }, | ||
| Providers: testAccProviders, | ||
| Steps: []resource.TestStep{ | ||
| { | ||
| Config: testAccDataSourceKeyVaultAccessPolicy("Secret & Certificate Management"), | ||
| Check: resource.ComposeTestCheckFunc( | ||
| resource.TestCheckNoResourceAttr(dataSourceName, "key_permissions"), | ||
| resource.TestCheckResourceAttr(dataSourceName, "secret_permissions.#", "7"), | ||
| resource.TestCheckResourceAttr(dataSourceName, "certificate_permissions.#", "12"), | ||
| ), | ||
| }, | ||
| }, | ||
| }) | ||
| } | ||
|
|
||
| func TestAccDataSourceAzureRMKeyVaultAccessPolicy_keySecretCertificate(t *testing.T) { | ||
| dataSourceName := "data.azurerm_key_vault_access_policy.test" | ||
| resource.Test(t, resource.TestCase{ | ||
| PreCheck: func() { testAccPreCheck(t) }, | ||
| Providers: testAccProviders, | ||
| Steps: []resource.TestStep{ | ||
| { | ||
| Config: testAccDataSourceKeyVaultAccessPolicy("Key, Secret, & Certificate Management"), | ||
| Check: resource.ComposeTestCheckFunc( | ||
| resource.TestCheckResourceAttr(dataSourceName, "key_permissions.#", "9"), | ||
| resource.TestCheckResourceAttr(dataSourceName, "secret_permissions.#", "7"), | ||
| resource.TestCheckResourceAttr(dataSourceName, "certificate_permissions.#", "12"), | ||
| ), | ||
| }, | ||
| }, | ||
| }) | ||
| } | ||
|
|
||
| func testAccDataSourceKeyVaultAccessPolicy(name string) string { | ||
| return fmt.Sprintf(` | ||
| data "azurerm_key_vault_access_policy" "test" { | ||
| name = "%s" | ||
| } | ||
| `, name) | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor does the Portal have the second comma?