Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: making the clients public #4325

Merged
merged 12 commits into from
Sep 13, 2019
Merged

refactor: making the clients public #4325

merged 12 commits into from
Sep 13, 2019

Conversation

tombuildsstuff
Copy link
Contributor

This PR makes the Service Clients public to ease the migration away from the ArmClient struct.

I've intentionally started at the bottom and skipped the web client since there's a couple of open PR's for this I've tried to avoid conflicting with. This PR also adds a NOTE explaining all new fields should be public

@tombuildsstuff tombuildsstuff added this to the v1.34.0 milestone Sep 13, 2019
@tombuildsstuff tombuildsstuff requested a review from a team September 13, 2019 15:24
@ghost ghost added the size/XL label Sep 13, 2019
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@katbyte katbyte merged commit 6716f42 into master Sep 13, 2019
@katbyte katbyte deleted the refactor/public-fields branch September 13, 2019 17:09
@ghost
Copy link

ghost commented Sep 18, 2019

This has been released in version 1.34.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.34.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Mar 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants