Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Resource: Bastion Host - fixes merge conflicts on #4096 #4347

Closed
wants to merge 11 commits into from

Conversation

gambtho
Copy link
Contributor

@gambtho gambtho commented Sep 17, 2019

fixes merge conflict and issues with sdk path on #4096

@gambtho gambtho changed the title Fixes merge conflicts with #4096 New Resource: Bastion Host - fixes merge conflicts on #4096 Sep 17, 2019
@gambtho gambtho force-pushed the pullrequest branch 8 times, most recently from 7d70d7c to 03a317b Compare September 18, 2019 20:29
@gambtho
Copy link
Contributor Author

gambtho commented Sep 30, 2019

@katbyte @tombuildsstuff concerns or suggestions on this one?

@katbyte
Copy link
Collaborator

katbyte commented Oct 2, 2019

Hi @gambtho,

Thank you for fixing these conflicts, however as the original PR has not been reviewed or the author have time to respond I am going to close this and keep the conversation there. Thanks again for trying to be helpful but we do want to try and favour the original author.

@katbyte katbyte closed this Oct 2, 2019
@gambtho
Copy link
Contributor Author

gambtho commented Oct 2, 2019

the original author gave this a thumbs up 👍

apologies if this created confusion or more work, just wanted to see this feature implemented

@ghost
Copy link

ghost commented Mar 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants