Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify DNS record resource_group_name usage in documentation. #4455

Merged
merged 1 commit into from
Sep 30, 2019

Conversation

johnyesberg
Copy link

For most resources, the resource_group_name attribute is used to specify the group
into which the new resource will be added. In the case of DNS records, the resource_group_name
specifies the group in which the parent can be found.

I had a DNS Zone in one resource group, and was attempting to create a CNAME record in a different resource group (as though that were possible). This wasn't working - 404 error indicated that the parent resource could not be found. When I realised that the resource_group_name attribute was used to locate the DNS Zone, rather than to select which group the new resources should be placed in, it all worked.

I wonder whether my proposed changes to the documentation might help others in future.

For most resources, the resource_group_name attribute is used to specify the group
into which the new resource will be added. In the case of DNS records, the resource_group_name
specifies the group in which the parent can be found.
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for this @johnyesberg

@tombuildsstuff tombuildsstuff added this to the v1.35.0 milestone Sep 30, 2019
@tombuildsstuff tombuildsstuff merged commit 7fba1a6 into hashicorp:master Sep 30, 2019
@ghost
Copy link

ghost commented Oct 4, 2019

This has been released in version 1.35.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.35.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Mar 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants