Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/devspace: updating to API version 2019-04-01 #4597

Merged
merged 2 commits into from
Oct 14, 2019
Merged

Conversation

tombuildsstuff
Copy link
Contributor

This PR updates the API version being used for Dev Space to 2019-04-01 - which requires that the host_suffix field becomes Computed rather than user-configurable.

Tests pass:

$ acctests azurerm TestAccAzureRMDevSpaceController_
=== RUN   TestAccAzureRMDevSpaceController_basic
=== PAUSE TestAccAzureRMDevSpaceController_basic
=== RUN   TestAccAzureRMDevSpaceController_requiresImport
--- SKIP: TestAccAzureRMDevSpaceController_requiresImport (0.00s)
    resource_arm_devspace_controller_test.go:42: Skipping since resources aren't required to be imported
=== CONT  TestAccAzureRMDevSpaceController_basic
--- PASS: TestAccAzureRMDevSpaceController_basic (1081.67s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm	1081.771s

Fixes #3805
Supersedes #4288

@tombuildsstuff tombuildsstuff added this to the v1.36.0 milestone Oct 11, 2019
@ghost ghost added the size/XXL label Oct 11, 2019
@tombuildsstuff tombuildsstuff changed the title D/devspace r/devspace: updating to API version 2019-04-01 Oct 11, 2019
@tombuildsstuff tombuildsstuff requested a review from a team October 11, 2019 08:23
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tombuildsstuff tombuildsstuff merged commit 7990187 into master Oct 14, 2019
@tombuildsstuff tombuildsstuff deleted the d/devspace branch October 14, 2019 09:01
tombuildsstuff added a commit that referenced this pull request Oct 14, 2019
@ghost
Copy link

ghost commented Oct 29, 2019

This has been released in version 1.36.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.36.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Nov 13, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bumping API version for devspace resource
2 participants