Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement azurerm_automation_certificate #4785

Merged
merged 13 commits into from
Dec 18, 2019
Merged

Implement azurerm_automation_certificate #4785

merged 13 commits into from
Dec 18, 2019

Commits on Dec 18, 2019

  1. #3881: azurerm_automation_certificate implementation

    @dowlingw @tombuildsstuff
    dowlingw authored and tombuildsstuff committed Dec 18, 2019
    Configuration menu
    Copy the full SHA
    e11d326 View commit details
    Browse the repository at this point in the history

  2. Update website/docs/r/automation_certificate.html.markdown 

    Co-Authored-By: kt <[email protected]>
    @dowlingw @katbyte @tombuildsstuff
    2 people authored and tombuildsstuff committed Dec 18, 2019
    Configuration menu
    Copy the full SHA
    6a59e3e View commit details
    Browse the repository at this point in the history

  3. Update azurerm/resource_arm_automation_certificate.go 

    Co-Authored-By: kt <[email protected]>
    @dowlingw @katbyte @tombuildsstuff
    2 people authored and tombuildsstuff committed Dec 18, 2019
    Configuration menu
    Copy the full SHA
    9b7fe95 View commit details
    Browse the repository at this point in the history

  4. Update azurerm/resource_arm_automation_certificate.go 

    Co-Authored-By: kt <[email protected]>
    @dowlingw @katbyte @tombuildsstuff
    2 people authored and tombuildsstuff committed Dec 18, 2019
    Configuration menu
    Copy the full SHA
    157991d View commit details
    Browse the repository at this point in the history

  5. Pull request feedback 

    --
* Validation for schema elements
* Stop setting Computed properties on creation
* Renamed/ordered variables for readability and consistency
    @dowlingw @tombuildsstuff
    dowlingw authored and tombuildsstuff committed Dec 18, 2019
    Configuration menu
    Copy the full SHA
    7435250 View commit details
    Browse the repository at this point in the history

  6. Moving test certificate to testdata folder 

    --
* Wrote script to re-generate test certificate
    @dowlingw @tombuildsstuff
    dowlingw authored and tombuildsstuff committed Dec 18, 2019
    Configuration menu
    Copy the full SHA
    6026485 View commit details
    Browse the repository at this point in the history

  7. Fixing missed variable renames from PR feedback

    @dowlingw @tombuildsstuff
    dowlingw authored and tombuildsstuff committed Dec 18, 2019
    Configuration menu
    Copy the full SHA
    9448fc2 View commit details
    Browse the repository at this point in the history

  8. Certificate name now ForceNew based on API behaviour 

    --
* Adding test for certificate rename
* Refactor back into single CreateUpdate method
    @dowlingw @tombuildsstuff
    dowlingw authored and tombuildsstuff committed Dec 18, 2019
    Configuration menu
    Copy the full SHA
    7971578 View commit details
    Browse the repository at this point in the history

  9. Updating for new automation client

    @dowlingw @tombuildsstuff
    dowlingw authored and tombuildsstuff committed Dec 18, 2019
    Configuration menu
    Copy the full SHA
    a2d0be0 View commit details
    Browse the repository at this point in the history

  10. r/automation_certificate: fixing comments from code review

    @tombuildsstuff
    tombuildsstuff committed Dec 18, 2019
    Configuration menu
    Copy the full SHA
    6747157 View commit details
    Browse the repository at this point in the history

  11. r/automation_certificate: minor test fixes

    @tombuildsstuff
    tombuildsstuff committed Dec 18, 2019
    Configuration menu
    Copy the full SHA
    4230533 View commit details
    Browse the repository at this point in the history

  12. r/automation_certificate: adding a missing subcategory for registry docs

    @tombuildsstuff
    tombuildsstuff committed Dec 18, 2019
    Configuration menu
    Copy the full SHA
    d98d154 View commit details
    Browse the repository at this point in the history

  13. removing the unused AutomationClient

    @tombuildsstuff
    tombuildsstuff committed Dec 18, 2019
    Configuration menu
    Copy the full SHA
    86d0f36 View commit details
    Browse the repository at this point in the history