New Resource: azurerm_data_factory_trigger_schedule

azurerm/helpers/validate/datafactory.go

@@ -0,0 +1,30 @@
+package validate
+
+import (
+	"fmt"
+	"regexp"
+
+	"github.com/hashicorp/terraform-plugin-sdk/helper/schema"
+)
+
+func DataFactoryPipelineAndTriggerName() schema.SchemaValidateFunc {
+	return func(i interface{}, k string) (warnings []string, errors []error) {
+		value := i.(string)
+		if !regexp.MustCompile(`^[A-Za-z0-9_][^<>*#.%&:\\+?/]*$`).MatchString(value) {
+			errors = append(errors, fmt.Errorf("invalid name, see https://docs.microsoft.com/en-us/azure/data-factory/naming-rules %q: %q", k, value))
+		}
+
+		return warnings, errors
+	}
+}
+
+func DataFactoryName() schema.SchemaValidateFunc {
+	return func(i interface{}, k string) (warnings []string, errors []error) {
+		value := i.(string)
+		if !regexp.MustCompile(`^[A-Za-z0-9]+(?:-[A-Za-z0-9]+)*$`).MatchString(value) {
+			errors = append(errors, fmt.Errorf("invalid data_factory_name, see https://docs.microsoft.com/en-us/azure/data-factory/naming-rules %q: %q", k, value))
+		}
+
+		return warnings, errors
+	}
+}

azurerm/helpers/validate/datafactory_test.go

@@ -0,0 +1,57 @@
+package validate
+
+import "testing"
+
+func TestValidateDataFactoryPipelineAndTriggerName(t *testing.T) {
+	validNames := []string{
+		"validname",
+		"valid02name",
+		"validName1",
+	}
+	for _, v := range validNames {
+		_, errors := DataFactoryPipelineAndTriggerName()(v, "valid")
+		if len(errors) != 0 {
+			t.Fatalf("%q should be an invalid DataFactory Pipeline or Trigger Name: %q", v, errors)
+		}
+	}
+
+	invalidNames := []string{
+		"invalid.",
+		":@£",
+		">invalid",
+		"invalid&name",
+	}
+	for _, v := range invalidNames {
+		_, errors := DataFactoryPipelineAndTriggerName()(v, "invalid")
+		if len(errors) == 0 {
+			t.Fatalf("%q should be an invalid DataFactory Pipeline or Trigger Name", v)
+		}
+	}
+}
+
+func TestValidateDataFactoryName(t *testing.T) {
+	validNames := []string{
+		"valid-name",
+		"valid02-name",
+		"validName1",
+	}
+	for _, v := range validNames {
+		_, errors := DataFactoryName()(v, "valid")
+		if len(errors) != 0 {
+			t.Fatalf("%q should be a valid DataFactory Name: %q", v, errors)
+		}
+	}
+
+	invalidNames := []string{
+		"invalid.",
+		":@£",
+		">invalid",
+		"invalid&name",
+	}
+	for _, v := range invalidNames {
+		_, errors := DataFactoryName()(v, "invalid")
+		if len(errors) == 0 {
+			t.Fatalf("%q should be an invalid DataFactory Name", v)
+		}
+	}
+}

azurerm/internal/services/datafactory/client.go

@@ -11,6 +11,7 @@ type Client struct {
 	IntegrationRuntimesClient *datafactory.IntegrationRuntimesClient
 	LinkedServiceClient       *datafactory.LinkedServicesClient
 	PipelinesClient           *datafactory.PipelinesClient
+	TriggersClient            *datafactory.TriggersClient
 }
 
 func BuildClient(o *common.ClientOptions) *Client {
@@ -29,11 +30,15 @@ func BuildClient(o *common.ClientOptions) *Client {
 	PipelinesClient := datafactory.NewPipelinesClientWithBaseURI(o.ResourceManagerEndpoint, o.SubscriptionId)
 	o.ConfigureClient(&PipelinesClient.Client, o.ResourceManagerAuthorizer)
 
+	TriggersClient := datafactory.NewTriggersClientWithBaseURI(o.ResourceManagerEndpoint, o.SubscriptionId)
+	o.ConfigureClient(&TriggersClient.Client, o.ResourceManagerAuthorizer)
+
 	return &Client{
 		DatasetClient:             &DatasetClient,
 		FactoriesClient:           &FactoriesClient,
 		IntegrationRuntimesClient: &IntegrationRuntimesClient,
 		LinkedServiceClient:       &LinkedServiceClient,
 		PipelinesClient:           &PipelinesClient,
+		TriggersClient:            &TriggersClient,
 	}
 }

azurerm/provider.go

@@ -242,6 +242,7 @@ func Provider() terraform.ResourceProvider {
 		"azurerm_data_factory_linked_service_postgresql":             resourceArmDataFactoryLinkedServicePostgreSQL(),
 		"azurerm_data_factory_linked_service_sql_server":             resourceArmDataFactoryLinkedServiceSQLServer(),
 		"azurerm_data_factory_pipeline":                              resourceArmDataFactoryPipeline(),
+		"azurerm_data_factory_trigger_schedule":                      resourceArmDataFactoryTriggerSchedule(),
 		"azurerm_data_lake_analytics_account":                        resourceArmDataLakeAnalyticsAccount(),
 		"azurerm_data_lake_analytics_firewall_rule":                  resourceArmDataLakeAnalyticsFirewallRule(),
 		"azurerm_data_lake_store_file":                               resourceArmDataLakeStoreFile(),

azurerm/resource_arm_data_factory.go

@@ -2,7 +2,6 @@ package azurerm
 
 import (
 	"fmt"
-	"regexp"
 	"time"
 
 	"github.com/Azure/azure-sdk-for-go/services/datafactory/mgmt/2018-06-01/datafactory"
@@ -37,13 +36,10 @@ func resourceArmDataFactory() *schema.Resource {
 
 		Schema: map[string]*schema.Schema{
 			"name": {
-				Type:     schema.TypeString,
-				Required: true,
-				ForceNew: true,
-				ValidateFunc: validation.StringMatch(
-					regexp.MustCompile(`^[A-Za-z0-9]+(?:-[A-Za-z0-9]+)*$`),
-					`Invalid name for Data Factory, see https://docs.microsoft.com/en-us/azure/data-factory/naming-rules`,
-				),
+				Type:         schema.TypeString,
+				Required:     true,
+				ForceNew:     true,
+				ValidateFunc: validate.DataFactoryName(),
 			},
 
 			"location": azure.SchemaLocation(),

azurerm/resource_arm_data_factory_dataset_mysql.go

@@ -3,7 +3,6 @@ package azurerm
 import (
 	"fmt"
 	"log"
-	"regexp"
 	"time"
 
 	"github.com/Azure/azure-sdk-for-go/services/datafactory/mgmt/2018-06-01/datafactory"
@@ -44,13 +43,10 @@ func resourceArmDataFactoryDatasetMySQL() *schema.Resource {
 			},
 
 			"data_factory_name": {
-				Type:     schema.TypeString,
-				Required: true,
-				ForceNew: true,
-				ValidateFunc: validation.StringMatch(
-					regexp.MustCompile(`^[A-Za-z0-9]+(?:-[A-Za-z0-9]+)*$`),
-					`Invalid name for Data Factory, see https://docs.microsoft.com/en-us/azure/data-factory/naming-rules`,
-				),
+				Type:         schema.TypeString,
+				Required:     true,
+				ForceNew:     true,
+				ValidateFunc: validate.DataFactoryName(),
 			},
 
 			// There's a bug in the Azure API where this is returned in lower-case

azurerm/resource_arm_data_factory_dataset_postgresql.go

@@ -3,7 +3,6 @@ package azurerm
 import (
 	"fmt"
 	"log"
-	"regexp"
 	"time"
 
 	"github.com/Azure/azure-sdk-for-go/services/datafactory/mgmt/2018-06-01/datafactory"
@@ -44,13 +43,10 @@ func resourceArmDataFactoryDatasetPostgreSQL() *schema.Resource {
 			},
 
 			"data_factory_name": {
-				Type:     schema.TypeString,
-				Required: true,
-				ForceNew: true,
-				ValidateFunc: validation.StringMatch(
-					regexp.MustCompile(`^[A-Za-z0-9]+(?:-[A-Za-z0-9]+)*$`),
-					`Invalid name for Data Factory, see https://docs.microsoft.com/en-us/azure/data-factory/naming-rules`,
-				),
+				Type:         schema.TypeString,
+				Required:     true,
+				ForceNew:     true,
+				ValidateFunc: validate.DataFactoryName(),
 			},
 
 			// There's a bug in the Azure API where this is returned in lower-case

azurerm/resource_arm_data_factory_dataset_sql_server_table.go

@@ -3,7 +3,6 @@ package azurerm
 import (
 	"fmt"
 	"log"
-	"regexp"
 	"time"
 
 	"github.com/Azure/azure-sdk-for-go/services/datafactory/mgmt/2018-06-01/datafactory"
@@ -44,13 +43,10 @@ func resourceArmDataFactoryDatasetSQLServerTable() *schema.Resource {
 			},
 
 			"data_factory_name": {
-				Type:     schema.TypeString,
-				Required: true,
-				ForceNew: true,
-				ValidateFunc: validation.StringMatch(
-					regexp.MustCompile(`^[A-Za-z0-9]+(?:-[A-Za-z0-9]+)*$`),
-					`Invalid name for Data Factory, see https://docs.microsoft.com/en-us/azure/data-factory/naming-rules`,
-				),
+				Type:         schema.TypeString,
+				Required:     true,
+				ForceNew:     true,
+				ValidateFunc: validate.DataFactoryName(),
 			},
 
 			// There's a bug in the Azure API where this is returned in lower-case

azurerm/resource_arm_data_factory_integration_runtime_managed.go

@@ -42,13 +42,10 @@ func resourceArmDataFactoryIntegrationRuntimeManaged() *schema.Resource {
 			},
 
 			"data_factory_name": {
-				Type:     schema.TypeString,
-				Required: true,
-				ForceNew: true,
-				ValidateFunc: validation.StringMatch(
-					regexp.MustCompile(`^[A-Za-z0-9]+(?:-[A-Za-z0-9]+)*$`),
-					`Invalid name for Data Factory, see https://docs.microsoft.com/en-us/azure/data-factory/naming-rules`,
-				),
+				Type:         schema.TypeString,
+				Required:     true,
+				ForceNew:     true,
+				ValidateFunc: validate.DataFactoryName(),
 			},
 
 			"resource_group_name": azure.SchemaResourceGroupName(),

azurerm/resource_arm_data_factory_linked_service_data_lake_storage_gen2.go

@@ -2,12 +2,10 @@ package azurerm
 
 import (
 	"fmt"
-	"regexp"
 	"time"
 
 	"github.com/Azure/azure-sdk-for-go/services/datafactory/mgmt/2018-06-01/datafactory"
 	"github.com/hashicorp/terraform-plugin-sdk/helper/schema"
-	"github.com/hashicorp/terraform-plugin-sdk/helper/validation"
 	"github.com/terraform-providers/terraform-provider-azurerm/azurerm/helpers/azure"
 	"github.com/terraform-providers/terraform-provider-azurerm/azurerm/helpers/tf"
 	"github.com/terraform-providers/terraform-provider-azurerm/azurerm/helpers/validate"
@@ -43,13 +41,10 @@ func resourceArmDataFactoryLinkedServiceDataLakeStorageGen2() *schema.Resource {
 			},
 
 			"data_factory_name": {
-				Type:     schema.TypeString,
-				Required: true,
-				ForceNew: true,
-				ValidateFunc: validation.StringMatch(
-					regexp.MustCompile(`^[A-Za-z0-9]+(?:-[A-Za-z0-9]+)*$`),
-					`Invalid name for Data Factory, see https://docs.microsoft.com/en-us/azure/data-factory/naming-rules`,
-				),
+				Type:         schema.TypeString,
+				Required:     true,
+				ForceNew:     true,
+				ValidateFunc: validate.DataFactoryName(),
 			},
 
 			// There's a bug in the Azure API where this is returned in lower-case

azurerm/resource_arm_data_factory_linked_service_mysql.go

@@ -2,12 +2,10 @@ package azurerm
 
 import (
 	"fmt"
-	"regexp"
 	"time"
 
 	"github.com/Azure/azure-sdk-for-go/services/datafactory/mgmt/2018-06-01/datafactory"
 	"github.com/hashicorp/terraform-plugin-sdk/helper/schema"
-	"github.com/hashicorp/terraform-plugin-sdk/helper/validation"
 	"github.com/terraform-providers/terraform-provider-azurerm/azurerm/helpers/azure"
 	"github.com/terraform-providers/terraform-provider-azurerm/azurerm/helpers/tf"
 	"github.com/terraform-providers/terraform-provider-azurerm/azurerm/helpers/validate"
@@ -43,13 +41,10 @@ func resourceArmDataFactoryLinkedServiceMySQL() *schema.Resource {
 			},
 
 			"data_factory_name": {
-				Type:     schema.TypeString,
-				Required: true,
-				ForceNew: true,
-				ValidateFunc: validation.StringMatch(
-					regexp.MustCompile(`^[A-Za-z0-9]+(?:-[A-Za-z0-9]+)*$`),
-					`Invalid name for Data Factory, see https://docs.microsoft.com/en-us/azure/data-factory/naming-rules`,
-				),
+				Type:         schema.TypeString,
+				Required:     true,
+				ForceNew:     true,
+				ValidateFunc: validate.DataFactoryName(),
 			},
 
 			// There's a bug in the Azure API where this is returned in lower-case

azurerm/resource_arm_data_factory_linked_service_postgresql.go

@@ -2,12 +2,10 @@ package azurerm
 
 import (
 	"fmt"
-	"regexp"
 	"time"
 
 	"github.com/Azure/azure-sdk-for-go/services/datafactory/mgmt/2018-06-01/datafactory"
 	"github.com/hashicorp/terraform-plugin-sdk/helper/schema"
-	"github.com/hashicorp/terraform-plugin-sdk/helper/validation"
 	"github.com/terraform-providers/terraform-provider-azurerm/azurerm/helpers/azure"
 	"github.com/terraform-providers/terraform-provider-azurerm/azurerm/helpers/tf"
 	"github.com/terraform-providers/terraform-provider-azurerm/azurerm/helpers/validate"
@@ -43,13 +41,10 @@ func resourceArmDataFactoryLinkedServicePostgreSQL() *schema.Resource {
 			},
 
 			"data_factory_name": {
-				Type:     schema.TypeString,
-				Required: true,
-				ForceNew: true,
-				ValidateFunc: validation.StringMatch(
-					regexp.MustCompile(`^[A-Za-z0-9]+(?:-[A-Za-z0-9]+)*$`),
-					`Invalid name for Data Factory, see https://docs.microsoft.com/en-us/azure/data-factory/naming-rules`,
-				),
+				Type:         schema.TypeString,
+				Required:     true,
+				ForceNew:     true,
+				ValidateFunc: validate.DataFactoryName(),
 			},
 
 			// There's a bug in the Azure API where this is returned in lower-case

azurerm/resource_arm_data_factory_linked_service_sql_server.go

@@ -3,12 +3,10 @@ package azurerm
 import (
 	"fmt"
 	"log"
-	"regexp"
 	"time"
 
 	"github.com/Azure/azure-sdk-for-go/services/datafactory/mgmt/2018-06-01/datafactory"
 	"github.com/hashicorp/terraform-plugin-sdk/helper/schema"
-	"github.com/hashicorp/terraform-plugin-sdk/helper/validation"
 	"github.com/terraform-providers/terraform-provider-azurerm/azurerm/helpers/azure"
 	"github.com/terraform-providers/terraform-provider-azurerm/azurerm/helpers/tf"
 	"github.com/terraform-providers/terraform-provider-azurerm/azurerm/helpers/validate"
@@ -44,13 +42,10 @@ func resourceArmDataFactoryLinkedServiceSQLServer() *schema.Resource {
 			},
 
 			"data_factory_name": {
-				Type:     schema.TypeString,
-				Required: true,
-				ForceNew: true,
-				ValidateFunc: validation.StringMatch(
-					regexp.MustCompile(`^[A-Za-z0-9]+(?:-[A-Za-z0-9]+)*$`),
-					`Invalid name for Data Factory, see https://docs.microsoft.com/en-us/azure/data-factory/naming-rules`,
-				),
+				Type:         schema.TypeString,
+				Required:     true,
+				ForceNew:     true,
+				ValidateFunc: validate.DataFactoryName(),
 			},
 
 			// There's a bug in the Azure API where this is returned in lower-case