azurerm_key_vault - persist change for network_acls when allowing AzureServices

[richardzone]

This commit fix #2164.

How to reproduce the bug:

1. terraform apply the following Terraform configuration:

resource "azurerm_key_vault" "test_kv" {
  name                = "test-kv"
  ...

  network_acls {
    default_action             = "Allow"
    bypass                     = "AzureServices"
  }
}

2. Do a terraform plan with the same above configuration. It will incorrectly shows changes - Terraform trys to re-add the network_acls.

[richardzone]

@tombuildsstuff Hi Tom, I wonder if you have some time to help review the PR?

[mbfrahry]

Hey @richardzone, this looks good at a glance but could you add a test so we can confirm that this works/will continue to work

[katbyte]

@richardzone,

It sounds like this is a bug in the API not returning the values? Would it make sense to open an issue on the SDK and link to it in a comment here explaining why this is required?

[tombuildsstuff]

hey @richardzone

Thanks for this PR - apologies for the delayed review here!

After spending some time with this Pull Request and playing with the API to confirm the behaviour we believe it'd be better to return a default object matching the API behaviour for the network_acls block (e.g. defaulted to Allow, as the API behaves) - rather than omiting this from the diff. In order to achieve this we'd need to also make this block Computed - since this behaviour would be configured by default unless a user opted to change it.

As such whilst I'd like to thank you for this contribution - since these are fairly substantial changes, I hope you don't mind but I'm going to close this PR in favour of #5207 which implements this.

Thanks!

[richardzone]

No worries @tombuildsstuff , thanks for fixing this!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!