-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
azurerm_key_vault
- persist change for network_acls
when allowing AzureServices
#4805
Conversation
@tombuildsstuff Hi Tom, I wonder if you have some time to help review the PR? |
Hey @richardzone, this looks good at a glance but could you add a test so we can confirm that this works/will continue to work |
It sounds like this is a bug in the API not returning the values? Would it make sense to open an issue on the SDK and link to it in a comment here explaining why this is required? |
aazurerm_key_vault
- persist change for network_acls
when allowing AzureServices
aazurerm_key_vault
- persist change for network_acls
when allowing AzureServices
azurerm_key_vault
- persist change for network_acls
when allowing AzureServices
hey @richardzone Thanks for this PR - apologies for the delayed review here! After spending some time with this Pull Request and playing with the API to confirm the behaviour we believe it'd be better to return a default object matching the API behaviour for the As such whilst I'd like to thank you for this contribution - since these are fairly substantial changes, I hope you don't mind but I'm going to close this PR in favour of #5207 which implements this. Thanks! |
This PR supersedes #4805 by making the network_acls block computed with a default value based on the behaviour of the API $ acctests azurerm TestAccAzureRMKeyVault_networkAcls === RUN TestAccAzureRMKeyVault_networkAcls === PAUSE TestAccAzureRMKeyVault_networkAcls === RUN TestAccAzureRMKeyVault_networkAclsAllowed === PAUSE TestAccAzureRMKeyVault_networkAclsAllowed === CONT TestAccAzureRMKeyVault_networkAcls --- PASS: TestAccAzureRMKeyVault_networkAcls (347.28s) === CONT TestAccAzureRMKeyVault_networkAclsAllowed --- PASS: TestAccAzureRMKeyVault_networkAclsAllowed (247.89s) PASS ok github.com/terraform-providers/terraform-provider-azurerm/azurerm 595.221s Fixes #2164
No worries @tombuildsstuff , thanks for fixing this! |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
This commit fix #2164.
How to reproduce the bug:
terraform apply
the following Terraform configuration:terraform plan
with the same above configuration. It will incorrectly shows changes - Terraform trys to re-add the network_acls.