Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Resource: azurerm_kubernetes_cluster_node_pool #4899

Merged
merged 1 commit into from
Nov 21, 2019

Commits on Nov 20, 2019

  1. New Resource: azurerm_kubernetes_cluster_node_pool

    Co-authored-by: titilambert <[email protected]>
    Co-authored-by: djsly <[email protected]>
    
    This commit rebases @titilambert's original commits on top of #4898
    In addition it also makes a couple of changes:
    
    - The resource has been renamed `azurerm_kubernetes_cluster_node_pool` to match
      the latest terminology used in the Portal
    - The tests have been updated to use a Default Node Pool block in the AKS resource
    - During creation we now check for the presence of the parent Cluster and then
      confirm that the Default Node Pool is a VirtualMachineScaleSet type
    - Removes support for `orchestrator_version` temporarily - since this wants to be
      added to both the Default Node Pool and this resource at the same time/in the same PR
      since this wants some more specific tests (which'd be easier to review in a separate PR)
    - Matches the name/schema for all fields with the `default_node_pool` block in the AKS resource
    
    I've ended up `git reset HEAD~N` here to work around the merge conflict due to the large changes
    within the AKS resource in #4898, but this seemed like the most pragmatic way to ship these changes.
    tombuildsstuff committed Nov 20, 2019
    Configuration menu
    Copy the full SHA
    a1d6926 View commit details
    Browse the repository at this point in the history