Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/shared_image_version - support for the storage_account_type property #5212

Merged
merged 14 commits into from
Dec 18, 2019

Conversation

tombuildsstuff
Copy link
Contributor

This PR incorporates and supersedes #4865 by making the storage_account_type field computed & removing the List assertions from the tests since it's a Set.

Supersedes #4865
Fixes #4833

@tombuildsstuff
Copy link
Contributor Author

The tests for this in master are broken due to a change in the API - whilst they're still broken in this PR we're going to fix that post-merge so that this doesn't get blocked behind the upcoming refactor:

------- Stdout: -------
=== RUN   TestAccAzureRMSharedImageVersion_basic
=== PAUSE TestAccAzureRMSharedImageVersion_basic
=== CONT  TestAccAzureRMSharedImageVersion_basic
--- FAIL: TestAccAzureRMSharedImageVersion_basic (2475.42s)
    testing.go:630: Error destroying resource! WARNING: Dangling resources
        may exist. The full state and error is shown below.
        
        Error: errors during apply: Error deleting Shared Image Gallery "acctestsig191218170806559421" (Resource Group "acctestRG-191218170806559421"): compute.GalleriesClient#Delete: Failure sending request: StatusCode=0 -- Original Error: autorest/azure: Service returned an error. Status=<nil> Code="CannotDeleteResource" Message="Can not delete resource before nested resources are deleted."

Whilst that's clearly not ideal - once the refactor's done we can circle around and take a look at fixing this - else we're going to have a merge conflict/to start afresh here

@tombuildsstuff tombuildsstuff marked this pull request as ready for review December 18, 2019 20:00
@tombuildsstuff tombuildsstuff requested a review from a team December 18, 2019 20:00
@tombuildsstuff tombuildsstuff removed their assignment Dec 18, 2019
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@katbyte katbyte changed the title r/shared_image_version - fixing up #4865 r/shared_image_version - support for the storage_account_type property Dec 18, 2019
@katbyte katbyte merged commit 9a90417 into master Dec 18, 2019
katbyte added a commit that referenced this pull request Dec 18, 2019
@tombuildsstuff tombuildsstuff deleted the f/shared-image-version-storage-account-type branch December 19, 2019 13:28
@ghost
Copy link

ghost commented Jan 8, 2020

This has been released in version 1.40.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.40.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Mar 28, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants