Bug: azurerm_dns_aaaa_record - Normalize IPv6 addresses

azurerm/helpers/azure/network.go

@@ -0,0 +1,17 @@
+package azure
+
+import (
+	"fmt"
+	"net"
+)
+
+// CompressIPv6Address creates a canonicalized IPv6 address according to RFC5952
+func CompressIPv6Address(ipv6address string) (string, error) {
+	// Validate, if IPv6 address
+	ip := net.ParseIP(ipv6address)
+	if six := ip.To16(); six == nil {
+		return "", fmt.Errorf("%q is not a valid IPv6 address", ipv6address)
+	}
+
+	return ip.String(), nil
+}

azurerm/helpers/azure/network_test.go

@@ -0,0 +1,28 @@
+package azure
+
+import (
+	"testing"
+)
+
+func TestCompressIPv6Address(t *testing.T) {
+	cases := []struct {
+		input    string
+		expected string
+	}{
+		{
+			input:    "2607:f8b0:4005:0800:0000:0000:0000:1003",
+			expected: "2607:f8b0:4005:800::1003",
+		},
+		{
+			input:    "2001:0db8:1234:0000:0000:0000:0000:0000",
+			expected: "2001:db8:1234::",
+		},
+	}
+
+	for _, v := range cases {
+		actual, _ := CompressIPv6Address(v.input)
+		if v.expected != actual {
+			t.Fatalf("Expected %q but got %q", v.expected, actual)
+		}
+	}
+}

azurerm/internal/services/dns/resource_arm_dns_aaaa_record.go

@@ -2,6 +2,7 @@ package dns
 
 import (
 	"fmt"
+	"net"
 	"net/http"
 	"time"
 
@@ -48,9 +49,14 @@ func resourceArmDnsAAAARecord() *schema.Resource {
 			},
 
 			"records": {
-				Type:          schema.TypeSet,
-				Optional:      true,
-				Elem:          &schema.Schema{Type: schema.TypeString},
+				Type:     schema.TypeSet,
+				Optional: true,
+				Elem: &schema.Schema{
+					Type: schema.TypeString,
+					DiffSuppressFunc: func(k, old, new string, d *schema.ResourceData) bool {
+						return ipv6AddressDiffSuppress(k, old, new, d)
+					},
+				},
 				Set:           schema.HashString,
 				ConflictsWith: []string{"target_resource_id"},
 			},
@@ -207,6 +213,13 @@ func resourceArmDnsAaaaRecordDelete(d *schema.ResourceData, meta interface{}) er
 	return nil
 }
 
+func ipv6AddressDiffSuppress(_, old, new string, _ *schema.ResourceData) bool {
+	oldIp := net.ParseIP(old)
+	newIp := net.ParseIP(new)
+
+	return oldIp.Equal(newIp)
+}
+
 func expandAzureRmDnsAaaaRecords(input []interface{}) *[]dns.AaaaRecord {
 	records := make([]dns.AaaaRecord, len(input))