azurerm_storage_account - fix hanging destroy caused by multiple network rules

azurerm/helpers/common/arrays.go

@@ -0,0 +1,16 @@
+package common
+
+// Remove duplicates from the input array and return unify array (without duplicated elements)
+func RemoveDuplicatesFromStringArray(elements []string) []string {
+	visited := map[string]bool{}
+	result := []string{}
+
+	for v := range elements {
+		if !visited[elements[v]] {
+			visited[elements[v]] = true          // Mark the element as visited.
+			result = append(result, elements[v]) // Add it to the result.
+		}
+	}
+
+	return result
+}

azurerm/helpers/common/arrays_test.go

@@ -0,0 +1,38 @@
+package common
+
+import (
+	"reflect"
+	"testing"
+)
+
+func TestRemoveDuplicatesInStringArray(t *testing.T) {
+	cases := []struct {
+		Name   string
+		Input  []string
+		Result []string
+	}{
+		{
+			Name:   "contain duplicates",
+			Input:  []string{"string1", "string2", "string1", "string3", ""},
+			Result: []string{"string1", "string2", "string3", ""},
+		},
+		{
+			Name:   "does not contain duplicates",
+			Input:  []string{"string1", "string2", "string3", ""},
+			Result: []string{"string1", "string2", "string3", ""},
+		},
+		{
+			Name:   "empty array",
+			Input:  []string{},
+			Result: []string{},
+		},
+	}
+
+	for _, tc := range cases {
+		t.Run(tc.Name, func(t *testing.T) {
+			if !reflect.DeepEqual(RemoveDuplicatesFromStringArray(tc.Input), tc.Result) {
+				t.Fatalf("Expected TestRemoveDuplicatesInStringArray to return %v", tc.Result)
+			}
+		})
+	}
+}

azurerm/internal/locks/lock.go

@@ -1,6 +1,9 @@
 package locks
 
-import "github.com/hashicorp/terraform-plugin-sdk/helper/mutexkv"
+import (
+	"github.com/hashicorp/terraform-plugin-sdk/helper/mutexkv"
+	"github.com/terraform-providers/terraform-provider-azurerm/azurerm/helpers/common"
+)
 
 // armMutexKV is the instance of MutexKV for ARM resources
 var armMutexKV = mutexkv.NewMutexKV()
@@ -16,7 +19,9 @@ func ByName(name string, resourceType string) {
 }
 
 func MultipleByName(names *[]string, resourceType string) {
-	for _, name := range *names {
+	newSlice := common.RemoveDuplicatesFromStringArray(*names)
+
+	for _, name := range newSlice {
 		ByName(name, resourceType)
 	}
 }
@@ -31,7 +36,9 @@ func UnlockByName(name string, resourceType string) {
 }
 
 func UnlockMultipleByName(names *[]string, resourceType string) {
-	for _, name := range *names {
+	newSlice := common.RemoveDuplicatesFromStringArray(*names)
+
+	for _, name := range newSlice {
 		UnlockByName(name, resourceType)
 	}
 }