Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement: Data Source Documentation Cleanup #5643

Merged
merged 3 commits into from
Feb 7, 2020

Conversation

jackbatzner
Copy link
Contributor

In a different PR it was requested I remove all (Required) or (Optional) references.

@katbyte
we don't need required/optional on data source documentation, and could we use language consistent with the rest of the provider?

This PR cleans up the existing data source documentation to remove (Required) from all Argument Reference sections. And (Optional) from all Attributes Reference sections

Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mbfrahry mbfrahry changed the title Data Source documentation cleanup Improvement: Data Source Documentation Cleanup Feb 7, 2020
@mbfrahry mbfrahry merged commit 4d72d22 into hashicorp:master Feb 7, 2020
mbfrahry added a commit that referenced this pull request Feb 7, 2020
@jackbatzner jackbatzner deleted the datasource_doc_cleanup branch March 14, 2020 14:49
@ghost
Copy link

ghost commented Mar 14, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants