Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.0-dns #5794

Merged
merged 6 commits into from
Feb 18, 2020
Merged

2.0-dns #5794

merged 6 commits into from
Feb 18, 2020

Conversation

mbfrahry
Copy link
Member

No description provided.

@tombuildsstuff tombuildsstuff self-assigned this Feb 18, 2020
@tombuildsstuff tombuildsstuff added this to the v2.0.0 milestone Feb 18, 2020
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one comment (which I'll push a commit for) but this otherwise LGTM 👍

Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hit the trackpad mid-moving 🙃

```
$ TF_ACC=1 go test -v ./azurerm/internal/services/dns/tests/ -timeout=60m -run=TestAccAzureRMDnsNsRecord_withTags
=== RUN   TestAccAzureRMDnsNsRecord_withTags
=== PAUSE TestAccAzureRMDnsNsRecord_withTags
=== CONT  TestAccAzureRMDnsNsRecord_withTags
--- PASS: TestAccAzureRMDnsNsRecord_withTags (137.86s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/dns/tests	137.899s
```
@tombuildsstuff
Copy link
Contributor

Ignoring some 500's from Azure the tests look good:

Screenshot 2020-02-18 at 15 12 54

@tombuildsstuff
Copy link
Contributor

The failing build's been fixed via #5807 so this should otherwise be good 👍

@tombuildsstuff tombuildsstuff merged commit a8c4a69 into master Feb 18, 2020
@tombuildsstuff tombuildsstuff deleted the 2.0-dns branch February 18, 2020 18:07
tombuildsstuff added a commit that referenced this pull request Feb 18, 2020
@ghost
Copy link

ghost commented Feb 24, 2020

This has been released in version 2.0.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.0.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Mar 28, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants