-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds Resource azurerm_app_service_slot_virtual_network_swift_connection #5916
Merged
jackofallops
merged 17 commits into
hashicorp:master
from
nxt-engineering:azurerm_app_service_virtual_network_swift_connection_slot
Jul 6, 2020
Merged
Adds Resource azurerm_app_service_slot_virtual_network_swift_connection #5916
jackofallops
merged 17 commits into
hashicorp:master
from
nxt-engineering:azurerm_app_service_virtual_network_swift_connection_slot
Jul 6, 2020
Commits on Jun 17, 2020
-
Configuration menu - View commit details
-
Copy full SHA for d3b4b58 - Browse repository at this point
Copy the full SHA d3b4b58View commit details -
This is done by the maintainers after the PR is merged.
Configuration menu - View commit details
-
Copy full SHA for 8c6bf1b - Browse repository at this point
Copy the full SHA 8c6bf1bView commit details -
The examples for the `virtual_network_swift_connect` and `virtual_network_swift_connect_slot` have been updated to be nicer to read. I.e. everything _test_ has been replaced by _example_.
Configuration menu - View commit details
-
Copy full SHA for f2a8d06 - Browse repository at this point
Copy the full SHA f2a8d06View commit details -
Fixes the following error in the tests: "azurerm/internal/services/web/tests/resource_arm_app_service_slot_virtual_network_association_test.go:178:9: Sprintf format %d reads arg #6, but call has 5 args"
Configuration menu - View commit details
-
Copy full SHA for 4a176e8 - Browse repository at this point
Copy the full SHA 4a176e8View commit details -
Configuration menu - View commit details
-
Copy full SHA for bd4140e - Browse repository at this point
Copy the full SHA bd4140eView commit details -
Rename Tests for TestAccAzureRMAppServiceVirtualNetworkSwiftConnectio…
…nSlot ... to TestAccAzureRMAppServiceSlotVirtualNetworkSwiftConnection. The reason is that otherwise it's not possible to just run the test for `TestAccAzureRMAppServiceVirtualNetworkSwiftConnection`, as the `TestAccAzureRMAppServiceVirtualNetworkSwiftConnectionSlot` also matches that filter.
Configuration menu - View commit details
-
Copy full SHA for a37f2c3 - Browse repository at this point
Copy the full SHA a37f2c3View commit details -
The value `slot.Name` contains "app_service_name/slot_name". If this were retained as `slot_name` in the Terraform state then terraform would try to re-create the resource in every run. Thankfully, this was caught during the integration tests.
Configuration menu - View commit details
-
Copy full SHA for 08fe31d - Browse repository at this point
Copy the full SHA 08fe31dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5b0ffb1 - Browse repository at this point
Copy the full SHA 5b0ffb1View commit details -
Configuration menu - View commit details
-
Copy full SHA for e7938d5 - Browse repository at this point
Copy the full SHA e7938d5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1f31b3d - Browse repository at this point
Copy the full SHA 1f31b3dView commit details
Commits on Jul 2, 2020
-
Configuration menu - View commit details
-
Copy full SHA for e63a157 - Browse repository at this point
Copy the full SHA e63a157View commit details -
Configuration menu - View commit details
-
Copy full SHA for e0afabe - Browse repository at this point
Copy the full SHA e0afabeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4e9bec2 - Browse repository at this point
Copy the full SHA 4e9bec2View commit details
Commits on Jul 3, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 79ab0db - Browse repository at this point
Copy the full SHA 79ab0dbView commit details
Commits on Jul 6, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 96ade3c - Browse repository at this point
Copy the full SHA 96ade3cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9c7acbe - Browse repository at this point
Copy the full SHA 9c7acbeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 62812dd - Browse repository at this point
Copy the full SHA 62812ddView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.