Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds Resource azurerm_app_service_slot_virtual_network_swift_connection #5916

Merged
merged 17 commits into from
Jul 6, 2020
Merged

Adds Resource azurerm_app_service_slot_virtual_network_swift_connection #5916

merged 17 commits into from
Jul 6, 2020

Commits on Jun 17, 2020

  1. Adds Resource azurerm_app_service_virtual_network_swift_connection_slot

    @cimnine
    cimnine committed Jun 17, 2020
    Configuration menu
    Copy the full SHA
    d3b4b58 View commit details
    Browse the repository at this point in the history

  2. Remove CHANGELOG entry 

    This is done by the maintainers after the PR is merged.
    @cimnine
    cimnine committed Jun 17, 2020
    Configuration menu
    Copy the full SHA
    8c6bf1b View commit details
    Browse the repository at this point in the history

  3. Nicer examples 

    The examples for the `virtual_network_swift_connect` and `virtual_network_swift_connect_slot` have been updated to be nicer to read. I.e. everything _test_ has been replaced by _example_.
    @cimnine
    cimnine committed Jun 17, 2020
    Configuration menu
    Copy the full SHA
    f2a8d06 View commit details
    Browse the repository at this point in the history

  4. Fix sprintf number of args 

    Fixes the following error in the tests:
"azurerm/internal/services/web/tests/resource_arm_app_service_slot_virtual_network_association_test.go:178:9: Sprintf format %d reads arg #6, but call has 5 args"
    @cimnine
    cimnine committed Jun 17, 2020
    Configuration menu
    Copy the full SHA
    4a176e8 View commit details
    Browse the repository at this point in the history

  5. Add missing side navigation link

    @cimnine
    cimnine committed Jun 17, 2020
    Configuration menu
    Copy the full SHA
    bd4140e View commit details
    Browse the repository at this point in the history

  6. Rename Tests for TestAccAzureRMAppServiceVirtualNetworkSwiftConnectio… 

    …nSlot

... to TestAccAzureRMAppServiceSlotVirtualNetworkSwiftConnection.
The reason is that otherwise it's not possible to just run the test for `TestAccAzureRMAppServiceVirtualNetworkSwiftConnection`, as the `TestAccAzureRMAppServiceVirtualNetworkSwiftConnectionSlot` also matches that filter.
    @cimnine
    cimnine committed Jun 17, 2020
    Configuration menu
    Copy the full SHA
    a37f2c3 View commit details
    Browse the repository at this point in the history

  7. Retain correct slot name 

    The value `slot.Name` contains "app_service_name/slot_name". If this were retained as `slot_name` in the Terraform state then terraform would try to re-create the resource in every run. Thankfully, this was caught during the integration tests.
    @cimnine
    cimnine committed Jun 17, 2020
    Configuration menu
    Copy the full SHA
    08fe31d View commit details
    Browse the repository at this point in the history

  8. Fix acceptance test

    @cimnine
    cimnine committed Jun 17, 2020
    Configuration menu
    Copy the full SHA
    5b0ffb1 View commit details
    Browse the repository at this point in the history

  9. Extract ID parsing into a function

    @cimnine
    cimnine committed Jun 17, 2020
    Configuration menu
    Copy the full SHA
    e7938d5 View commit details
    Browse the repository at this point in the history

  10. Rename to azurerm_app_service_slot_virtual_network_swift_connection

    @cimnine
    cimnine committed Jun 17, 2020
    Configuration menu
    Copy the full SHA
    1f31b3d View commit details
    Browse the repository at this point in the history

Commits on Jul 2, 2020

  1. fixup resources and tests

    @jackofallops
    jackofallops committed Jul 2, 2020
    Configuration menu
    Copy the full SHA
    e63a157 View commit details
    Browse the repository at this point in the history

  2. added validation to slot name

    @jackofallops
    jackofallops committed Jul 2, 2020
    Configuration menu
    Copy the full SHA
    e0afabe View commit details
    Browse the repository at this point in the history

  3. tweaked slot example, updated arg order to alphabetical

    @jackofallops
    jackofallops committed Jul 2, 2020
    Configuration menu
    Copy the full SHA
    4e9bec2 View commit details
    Browse the repository at this point in the history

Commits on Jul 3, 2020

  1. Fix typo in SlotVirtualNetworkSwiftConnectionId type's name

    @cimnine
    cimnine committed Jul 3, 2020
    Configuration menu
    Copy the full SHA
    79ab0db View commit details
    Browse the repository at this point in the history

Commits on Jul 6, 2020

  1. typo in test name prefix

    @jackofallops
    jackofallops committed Jul 6, 2020
    Configuration menu
    Copy the full SHA
    96ade3c View commit details
    Browse the repository at this point in the history

  2. fix slot import test config

    @jackofallops
    jackofallops committed Jul 6, 2020
    Configuration menu
    Copy the full SHA
    9c7acbe View commit details
    Browse the repository at this point in the history

  3. fix slot import test data

    @jackofallops
    jackofallops committed Jul 6, 2020
    Configuration menu
    Copy the full SHA
    62812dd View commit details
    Browse the repository at this point in the history