-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reboot a VM only on managed disk resize #6162
reboot a VM only on managed disk resize #6162
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @shurikk
Thanks for this PR :)
Taking a look through this mostly LGTM - if we can fix up the documentation issue (and the tests pass) then this otherwise LGTM 👍
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thanks for pushing those changes @shurikk
hey @shurikk Thanks for this PR - I've spent a little time digging into this and it appears there's some more edge-cases here - as such I hope you don't mind but I'm going to push a couple of commits to rebase this PR (to include the changes from #6207) and then handle those edge-cases so that we can get this merged. Thanks! |
6e21752
to
e4aab7a
Compare
e4aab7a
to
3765f32
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
thanks 👍 |
any chance this fix goes into 1.xx branch? I know that 1.44 was the last one in 1.xx, this bug is somewhat dangerous. |
This has been released in version 2.3.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.3.0"
}
# ... other configuration ... |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
related to #6063
Fixes #6063