Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_key_vault allow case-insensitive sku_name #7290

Closed
wants to merge 1 commit into from

Conversation

magodo
Copy link
Collaborator

@magodo magodo commented Jun 11, 2020

KeyVault API (2016-10-01) allows case-insensitive Sku.name, so we need
to loosen the constraint also in terraform, which should not be a
breaking change.

(fixes: #7254)

KeyVault API (2016-10-01) allows case-insensitive `Sku.name`, so we need
to loose the constraint also in terraform, which should not be a
breaking change.
@ghost ghost added the size/XS label Jun 11, 2020
@katbyte
Copy link
Collaborator

katbyte commented Jun 11, 2020

@magodo - this sounds like a bug on the API/portal side for allowing the wrong casing to be used? and we should open an issue on the sdk/specs to bring attention to the service team?

@katbyte
Copy link
Collaborator

katbyte commented Jul 9, 2020

I'm going to close this for now as its been a month without a response - can reopen it once we're ready to move forward

@katbyte katbyte closed this Jul 9, 2020
@magodo
Copy link
Collaborator Author

magodo commented Jul 10, 2020

@katbyte I have submitted the issue and put the link in code. Do you think it is feasible to reopen this PR and label it as breaking change?

@tombuildsstuff
Copy link
Contributor

@magodo in this instance it sounds like the casing in the Swagger needs updating?

@magodo
Copy link
Collaborator Author

magodo commented Jul 10, 2020

@tombuildsstuff The API allows either case. Whilst I feel this PR should be safe to be merged as it just loosens some constraint.

@ghost
Copy link

ghost commented Aug 9, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Aug 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Azure displays SKU as "Standard" but when running Terraform plan it tries to change it to "standard"
3 participants