Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SDK12: Migrating Networking over to the new SDK #738

Merged
merged 5 commits into from
Jan 23, 2018
Merged

SDK12: Migrating Networking over to the new SDK #738

merged 5 commits into from
Jan 23, 2018

Conversation

tombuildsstuff
Copy link
Contributor

@tombuildsstuff tombuildsstuff commented Jan 22, 2018 •
edited
Loading

Tests:

  • Data Sources
  • Application Gateway
  • Express Route
  • Load Balancer
  • Local Network Gateway
  • Network Interfaces
  • Network Security Group
  • Network Security Rule
  • Public IP
  • Route
  • RouteTable
  • Subnet
  • Virtual Network
  • Virtual Network Peering

@tombuildsstuff tombuildsstuff added this to the 1.0.2 milestone Jan 22, 2018
@tombuildsstuff
Copy link
Contributor Author

Data Source Tests pass:

tests-data-source

Express Route Circuit tests pass:

tests-express-route-circuit

Local Network Gateway tests pass:

tests-local-network-gateway

Routes / Route Table tests pass:

tests-routes

Subnet tests pass:

tests-subnets

Virtual Network / Virtual Network Peering tests pass:

tests-virtual-networks

paultyng
paultyng approved these changes Jan 22, 2018
View reviewed changes
Copy link
Contributor

@paultyng paultyng left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a lot to read through, but lgtm

@tombuildsstuff
Copy link
Contributor Author

The Application Gateway tests are no less broken than they are at the moment (due to the broken API) - so deleting the Subnet fails (which is a known issue)

    * azurerm_subnet.test: Error waiting for completion for Subnet "subnet-342152097063449329" (VN "acctest-vnet-342152097063449329" / Resource Group "acctestrg-342152097063449329"): Long running operation terminated with status 'Failed': Code="InternalServerError" Message="An error occurred."

screen shot 2018-01-23 at 13 48 18

As such I'm going to check that off, for the moment.

@tombuildsstuff
Copy link
Contributor Author

Load Balancer tests pass:

screen shot 2018-01-23 at 15 40 40

@tombuildsstuff
Copy link
Contributor Author

Network Security Group / Rule tests pass:

screen shot 2018-01-23 at 15 46 55

@tombuildsstuff
Copy link
Contributor Author

Network Interfaces test:

screen shot 2018-01-23 at 15 45 55

@tombuildsstuff
Copy link
Contributor Author

Public IP tests pass:

screen shot 2018-01-23 at 15 52 09

@tombuildsstuff tombuildsstuff merged commit 51d26fd into master Jan 23, 2018
@tombuildsstuff tombuildsstuff deleted the sdk-migration-network branch January 23, 2018 14:55
@dominik-lekse dominik-lekse mentioned this pull request Jan 24, 2018
Merged
@ghost
Copy link

ghost commented Mar 31, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@paultyng paultyng paultyng approved these changes

Assignees
No one assigned
Labels
dependencies
Projects
None yet
Milestone
v1.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@tombuildsstuff @paultyng @genevieve