Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Resource/New Data Source: azurerm_attestation_provider #7885

Merged
merged 45 commits into from
Sep 4, 2020
Merged

New Resource/New Data Source: azurerm_attestation_provider #7885

merged 45 commits into from
Sep 4, 2020

Conversation

WodansSon
Copy link
Collaborator

@WodansSon WodansSon commented Jul 24, 2020 •
edited
Loading

Adding support for the attestation provider.

@WodansSon WodansSon changed the title [WIP] New Resource/ New Data Source: azurerm_attestation [WIP] New Resource/New Data Source: azurerm_attestation Jul 24, 2020
@WodansSon WodansSon changed the title [WIP] New Resource/New Data Source: azurerm_attestation New Resource/New Data Source: azurerm_attestation Aug 19, 2020
@WodansSon WodansSon added this to the v2.24.0 milestone Aug 19, 2020
@WodansSon WodansSon modified the milestones: v2.24.0, Future Aug 19, 2020
@WodansSon
Copy link
Collaborator Author

I have removed this resource from the v2.24.0 release of the provider since we have re-opened design discussions with the service team about the best way to pass the JSON Web Key Set x5c RFC7517 Section 4.7 through terraform to the service teams RP.

@WodansSon WodansSon modified the milestones: Future, v2.26.0 Aug 29, 2020
WodansSon and others added 8 commits September 2, 2020 20:06
@WodansSon @tombuildsstuff
Update website/docs/r/attestation.html.markdown
f203084 
Co-authored-by: Tom Harvey <[email protected]>
@WodansSon @tombuildsstuff
Update website/docs/r/attestation.html.markdown
c7479a2 
Co-authored-by: Tom Harvey <[email protected]>
@WodansSon @tombuildsstuff
Update website/docs/r/attestation.html.markdown
c8153fc 
Co-authored-by: Tom Harvey <[email protected]>
@WodansSon @tombuildsstuff
Update website/docs/r/attestation.html.markdown
3732a8f 
Co-authored-by: Tom Harvey <[email protected]>
@WodansSon @tombuildsstuff
Update website/docs/r/attestation.html.markdown
3bdf89d 
Co-authored-by: Tom Harvey <[email protected]>
@WodansSon @tombuildsstuff
Update website/docs/r/attestation.html.markdown
0d71d8c 
Co-authored-by: Tom Harvey <[email protected]>
@WodansSon
Merge branch 'master' of https://github.com/terraform-providers/terra…
a412300 
…form-provider-azurerm into nr_attestation
@WodansSon
Updates for PR comments
e5ad51c
@WodansSon WodansSon changed the title New Resource/New Data Source: azurerm_attestation New Resource/New Data Source: azurerm_attestation_provider Sep 3, 2020
tombuildsstuff
tombuildsstuff approved these changes Sep 3, 2020
View reviewed changes
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few minor points to fix but this otherwise LGTM 👍

azurerm/internal/services/attestation/tests/attestation_data_source_test.go Outdated Show resolved Hide resolved
azurerm/internal/services/attestation/tests/attestation_data_source_test.go Outdated Show resolved Hide resolved
website/docs/r/attestation.html.markdown Outdated Show resolved Hide resolved
website/docs/r/attestation.html.markdown Outdated Show resolved Hide resolved
website/docs/r/attestation.html.markdown Outdated Show resolved Hide resolved
website/docs/r/attestation.html.markdown Outdated Show resolved Hide resolved
@tombuildsstuff tombuildsstuff modified the milestones: v2.26.0, v2.27.0 Sep 3, 2020
WodansSon and others added 7 commits September 3, 2020 12:51
@WodansSon
Copy link
Collaborator Author

image

@WodansSon WodansSon merged commit c505538 into master Sep 4, 2020
@WodansSon WodansSon deleted the nr_attestation branch September 4, 2020 22:24
WodansSon added a commit that referenced this pull request Sep 4, 2020
@WodansSon
updating to include #7885
66d5dc6
@ghost
Copy link

ghost commented Sep 10, 2020

This has been released in version 2.27.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.27.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Oct 5, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Oct 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tombuildsstuff tombuildsstuff tombuildsstuff approved these changes

@katbyte katbyte Awaiting requested review from katbyte

@jackofallops jackofallops Awaiting requested review from jackofallops

Assignees

@WodansSon WodansSon

Labels
dependencies documentation new-data-source new-resource service/attestation size/XXL
Projects
None yet
Milestone
v2.27.0
Development

Successfully merging this pull request may close these issues.
2 participants
@WodansSon @tombuildsstuff