Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added an option to have 0 in disk_size_gb property of managed_disk #800

Merged
merged 1 commit into from
Feb 8, 2018
Merged

Added an option to have 0 in disk_size_gb property of managed_disk #800

merged 1 commit into from
Feb 8, 2018

Conversation

echuvyrov
Copy link
Contributor

Added tests and changed validation to allow managed disks of size "0" (unset).

@tombuildsstuff
Copy link
Contributor

Tests pass:

screen shot 2018-02-08 at 06 21 30

Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tombuildsstuff tombuildsstuff merged commit dc7a4c2 into hashicorp:master Feb 8, 2018
tombuildsstuff added a commit that referenced this pull request Feb 8, 2018
@ghost
Copy link

ghost commented Mar 31, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants