Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: cleaning up load balancers & adding validation to Load Balancer ID's & at import time #8172

Merged
merged 15 commits into from
Aug 20, 2020
Merged

refactor: cleaning up load balancers & adding validation to Load Balancer ID's & at import time #8172

merged 15 commits into from
Aug 20, 2020

Commits on Aug 19, 2020

  1. loadbalancers: adding an ID parser

    @tombuildsstuff
    tombuildsstuff committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    bda1c13 View commit details
    Browse the repository at this point in the history

  2. r/loadbalancer_backend_address_pool: using a consistent ID parser

    @tombuildsstuff
    tombuildsstuff committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    cfbf7fa View commit details
    Browse the repository at this point in the history

  3. r/lb_nat_pool: switching to use specific ID parsers

    @tombuildsstuff
    tombuildsstuff committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    6d4da9c View commit details
    Browse the repository at this point in the history

  4. r/lb_nat_rule: switching to use specific ID parsers

    @tombuildsstuff
    tombuildsstuff committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    9dc7517 View commit details
    Browse the repository at this point in the history

  5. r/loadbalancer_outbound_rule: parsing using a consistent id func

    @tombuildsstuff
    tombuildsstuff committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    3713370 View commit details
    Browse the repository at this point in the history

  6. r/loadbalancer_probe: parsing using a consistent method

    @tombuildsstuff
    tombuildsstuff committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    35c4f6a View commit details
    Browse the repository at this point in the history

  7. r/loadbalancer_rule: switching to use a consistent id parsing method

    @tombuildsstuff
    tombuildsstuff committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    f5d0df0 View commit details
    Browse the repository at this point in the history

  8. refactor: removing the legacy parseID method

    @tombuildsstuff
    tombuildsstuff committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    c15702c View commit details
    Browse the repository at this point in the history

  9. refactor: retrieveLoadBalancerById now takes the ID

    @tombuildsstuff
    tombuildsstuff committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    59fe7d6 View commit details
    Browse the repository at this point in the history

  10. refactor: passing ctx/client into the retrieveLoadBalancerById method

    @tombuildsstuff
    tombuildsstuff committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    6ab5e5e View commit details
    Browse the repository at this point in the history

  11. refactor: adding validation it's a Load Balancer ID being passed in

    @tombuildsstuff
    tombuildsstuff committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    7dcb88a View commit details
    Browse the repository at this point in the history

  12. refactor: adding import time validation

    @tombuildsstuff
    tombuildsstuff committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    bbafb6c View commit details
    Browse the repository at this point in the history

Commits on Aug 20, 2020

  1. Update azurerm/internal/services/network/lb_rule_resource.go 

    Co-authored-by: Steve <[email protected]>
    @tombuildsstuff @jackofallops
    tombuildsstuff and jackofallops authored Aug 20, 2020
    Configuration menu
    Copy the full SHA
    7051d61 View commit details
    Browse the repository at this point in the history

  2. Update azurerm/internal/services/network/lb_rule_resource.go 

    Co-authored-by: Steve <[email protected]>
    @tombuildsstuff @jackofallops
    tombuildsstuff and jackofallops authored Aug 20, 2020
    Configuration menu
    Copy the full SHA
    7346c00 View commit details
    Browse the repository at this point in the history

  3. Update azurerm/internal/services/network/lb_outbound_rule_resource.go 

    Co-authored-by: Steve <[email protected]>
    @tombuildsstuff @jackofallops
    tombuildsstuff and jackofallops authored Aug 20, 2020
    Configuration menu
    Copy the full SHA
    9abb3bb View commit details
    Browse the repository at this point in the history