Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New resource/data source azurerm_data_share_dataset_kusto_database #8544

Merged
merged 2 commits into from
Nov 9, 2020

Conversation

yupwei68
Copy link
Contributor

Partially fix #6480

Sub PR of : #7064

=== RUN TestAccDataSourceAzureRMDataShareDatasetKustoDatabase_basic
=== PAUSE TestAccDataSourceAzureRMDataShareDatasetKustoDatabase_basic
=== CONT TestAccDataSourceAzureRMDataShareDatasetKustoDatabase_basic
--- PASS: TestAccDataSourceAzureRMDataShareDatasetKustoDatabase_basic (1602.41s)

=== RUN TestAccAzureRMCloudEndpoint_basic
=== PAUSE TestAccAzureRMCloudEndpoint_basic
=== CONT TestAccAzureRMCloudEndpoint_basic
--- PASS: TestAccAzureRMCloudEndpoint_basic (390.42s)
=== RUN TestAccAzureRMCloudEndpoint_requiresImport
=== PAUSE TestAccAzureRMCloudEndpoint_requiresImport
=== CONT TestAccAzureRMCloudEndpoint_requiresImport
--- PASS: TestAccAzureRMCloudEndpoint_requiresImport (400.43s)

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pr @yupwei68 - overall this looks good aside from some comments i've left inline

@yupwei68
Copy link
Contributor Author

yupwei68 commented Oct 9, 2020

@katbyte Thanks for your comments. Changes have been pushed. Please continue reviewing.

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM now 👍

@katbyte katbyte merged commit b71a28b into hashicorp:master Nov 9, 2020
katbyte added a commit that referenced this pull request Nov 9, 2020
@ghost
Copy link

ghost commented Nov 12, 2020

This has been released in version 2.36.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.36.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Dec 10, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Dec 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for [Data Share]
2 participants