-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New resource/data source azurerm_data_share_dataset_kusto_database
#8544
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the pr @yupwei68 - overall this looks good aside from some comments i've left inline
...erm/internal/services/datashare/tests/resource_arm_data_share_dataset_kusto_database_test.go
Outdated
Show resolved
Hide resolved
...erm/internal/services/datashare/tests/resource_arm_data_share_dataset_kusto_database_test.go
Show resolved
Hide resolved
...erm/internal/services/datashare/tests/resource_arm_data_share_dataset_kusto_database_test.go
Outdated
Show resolved
Hide resolved
...erm/internal/services/datashare/tests/resource_arm_data_share_dataset_kusto_database_test.go
Outdated
Show resolved
Hide resolved
...erm/internal/services/datashare/tests/resource_arm_data_share_dataset_kusto_database_test.go
Outdated
Show resolved
Hide resolved
...erm/internal/services/datashare/tests/resource_arm_data_share_dataset_kusto_database_test.go
Show resolved
Hide resolved
@katbyte Thanks for your comments. Changes have been pushed. Please continue reviewing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM now 👍
This has been released in version 2.36.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.36.0"
}
# ... other configuration ... |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
Partially fix #6480
Sub PR of : #7064
=== RUN TestAccDataSourceAzureRMDataShareDatasetKustoDatabase_basic
=== PAUSE TestAccDataSourceAzureRMDataShareDatasetKustoDatabase_basic
=== CONT TestAccDataSourceAzureRMDataShareDatasetKustoDatabase_basic
--- PASS: TestAccDataSourceAzureRMDataShareDatasetKustoDatabase_basic (1602.41s)
=== RUN TestAccAzureRMCloudEndpoint_basic
=== PAUSE TestAccAzureRMCloudEndpoint_basic
=== CONT TestAccAzureRMCloudEndpoint_basic
--- PASS: TestAccAzureRMCloudEndpoint_basic (390.42s)
=== RUN TestAccAzureRMCloudEndpoint_requiresImport
=== PAUSE TestAccAzureRMCloudEndpoint_requiresImport
=== CONT TestAccAzureRMCloudEndpoint_requiresImport
--- PASS: TestAccAzureRMCloudEndpoint_requiresImport (400.43s)