Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New resource azurerm_stream_analytics_job #888

Closed
wants to merge 146 commits into from

Conversation

shelleybess
Copy link
Contributor

New Stream Analytics resource for provider.

girishramnani and others added 30 commits September 28, 2017 11:49
As the refresh function ( read lifecyle ) of the iothub
resource is only dependent on the id of the resource to
genarate the state StatePassthrough method is used
@shelleybess shelleybess changed the title WIP: New resource azurerm_stream_analytics_job New resource azurerm_stream_analytics_job Jun 25, 2018
@metacpp metacpp requested review from katbyte, JunyiYi and metacpp and removed request for metacpp August 2, 2018 23:41
@metacpp metacpp self-assigned this Aug 2, 2018
@metacpp metacpp added this to the Soon milestone Aug 2, 2018
@tombuildsstuff tombuildsstuff modified the milestones: Soon, 1.19.0 Oct 25, 2018
@tombuildsstuff tombuildsstuff modified the milestones: 1.19.0, 1.20.0 Nov 15, 2018
@tombuildsstuff tombuildsstuff modified the milestones: 1.20.0, 1.21.0 Dec 3, 2018
@tombuildsstuff tombuildsstuff modified the milestones: 1.21.0, Future Jan 3, 2019
@katbyte katbyte removed their assignment Jan 3, 2019
@r0bnet
Copy link
Contributor

r0bnet commented Feb 19, 2019

How's the status about this topic? Would like to use the stream analytics job to avoid a workaround with the ARM deployment.

@maxbog
Copy link
Contributor

maxbog commented Feb 22, 2019

@shelleybess @katbyte I'm also interested in getting this PR merged ASAP. Is there anything I can help with? What is the status of this PR?

@maxbog
Copy link
Contributor

maxbog commented Apr 4, 2019

@katbyte This PR seems abandoned by the original author. I'll add documentation, review the code, test it a bit and submit a new PR from my fork with the same commits and my modifications.

@tombuildsstuff tombuildsstuff self-assigned this Apr 10, 2019
@tombuildsstuff tombuildsstuff removed this from the Future milestone Apr 10, 2019
@tombuildsstuff
Copy link
Contributor

hey @shelleybess

Firstly, apologies for the delay with this PR - it's been sat at the bottom of the PR Review list for far too long (which is totally my fault!).

In order to understand how we could proceed with support for Stream Analytics I've spent some time looking into what these resources could look like; ultimately since there can only be a single transformation we've ended up merging this into the Stream Analytics Job resource. Since this codebase has diverged quite substantially since this PR was first opened - rather than trying to rebase this and update the Azure SDK to to the latest version, after some investigation it appeared to be faster to start over using the new API (branched from master) than to try and pull these changes in.

As such I'm going to close this PR for the moment - but I'd like to thank you for this contribution; whilst I appreciate this isn't ideal since it means the commits done in this PR won't make it into the Azure Provider (and also that this PR has been idle for so long) - I'll shortly be opening a PR to add support for Stream Analytics Jobs (which should make it into the v1.25 release of the AzureRM Provider) - and support for the remaining resources (Inputs, Outputs and Functions) should make it into the subsequent release.

Thanks!

@ghost
Copy link

ghost commented May 11, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators May 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants