Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for os_disk_image_size_gb to get the disk size of the image #8904

Merged
merged 4 commits into from
Oct 20, 2020
Merged

Conversation

harshavmb
Copy link
Contributor

Adding support for os_disk_image_size to get the disk size of the image

Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @harshavmb

Thanks for this PR - taking a look through this is looking good, if we can fix up the comments then this otherwise looks good to me 👍

Thanks!

…orp's suggestion...

Defaulting osDiskImageSize to 0
@harshavmb
Copy link
Contributor Author

hey @harshavmb

Thanks for this PR - taking a look through this is looking good, if we can fix up the comments then this otherwise looks good to me 👍

Thanks!

Hi @tombuildsstuff ,

Thanks for the review. I made suggested changes. Hope you are okay with these changes!

Thanks,
Harsha

@ghost ghost removed the waiting-response label Oct 19, 2020
@harshavmb harshavmb changed the title Adding support for os_disk_image_size to get the disk size of the image Adding support for os_disk_image_size_gb to get the disk size of the image Oct 19, 2020
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for this @harshavmb

@tombuildsstuff tombuildsstuff added this to the v2.33.0 milestone Oct 20, 2020
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for this @harshavmb

@tombuildsstuff tombuildsstuff merged commit 9634e9a into hashicorp:master Oct 20, 2020
tombuildsstuff added a commit that referenced this pull request Oct 20, 2020
@ghost
Copy link

ghost commented Oct 22, 2020

This has been released in version 2.33.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.33.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Nov 19, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Nov 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants