-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support health extension for rolling ugrade mode #9136
Merged
jackofallops
merged 13 commits into
hashicorp:master
from
ArcturusZhang:vmss-health-extension
Apr 14, 2021
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
01c9cef
Support health extension for automatic ugrade mode
ArcturusZhang 84a59e5
Fix
ArcturusZhang 14713cb
Resolve comments
ArcturusZhang dc55885
Fix test
ArcturusZhang 3cb453d
terrafmt
ArcturusZhang a365751
Merge remote-tracking branch 'origin/master' into vmss-health-extension
ArcturusZhang 9e067d5
resolve comments
ArcturusZhang ee09c45
terrafmt
ArcturusZhang 3c9dffe
gofmt
ArcturusZhang 1914a2d
minor change
ArcturusZhang fae700e
rename one test case to align with others
ArcturusZhang ff46891
fix test case
ArcturusZhang 09726f3
fixing test cases
ArcturusZhang File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we'll get here, line 352 above will kick us out first if
health_probe_id
is unset, so that will need investigating for refactoring.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah... something is messed up during the merging from master. I need to check these carefully again.