New resource/ data source `azurerm_iothub_digital_twins` #9212

yupwei68 · 2020-11-09T09:15:24Z

=== RUN TestAccAzureRMDigitalTwins_basic
=== PAUSE TestAccAzureRMDigitalTwins_basic
=== CONT TestAccAzureRMDigitalTwins_basic
--- PASS: TestAccAzureRMDigitalTwins_basic (170.28s)
=== RUN TestAccAzureRMDigitalTwins_requiresImport
=== PAUSE TestAccAzureRMDigitalTwins_requiresImport
=== CONT TestAccAzureRMDigitalTwins_requiresImport
--- PASS: TestAccAzureRMDigitalTwins_requiresImport (147.93s)
=== RUN TestAccAzureRMDigitalTwins_complete
=== PAUSE TestAccAzureRMDigitalTwins_complete
=== CONT TestAccAzureRMDigitalTwins_complete
--- PASS: TestAccAzureRMDigitalTwins_complete (170.48s)
=== RUN TestAccAzureRMDigitalTwins_update
=== PAUSE TestAccAzureRMDigitalTwins_update
=== CONT TestAccAzureRMDigitalTwins_update
--- PASS: TestAccAzureRMDigitalTwins_update (284.05s)

Process finished with exit code 0

WodansSon

@yupwei68 Thank you for this PR, it's looking really good so far but I left a few comments. If you can address those I think this will be good to go! 🚀

azurerm/internal/services/iothub/iothub_digital_twins_resource.go

azurerm/internal/services/iothub/tests/iothub_digital_twins_resource_test.go

azurerm/internal/services/iothub/validate/digital_twins.go

azurerm/internal/services/iothub/validate/digital_twins_test.go

yupwei68 · 2020-11-17T05:17:34Z

Thanks @WodansSon for your comments. Corresponding changes have been pushed. Please continue reviewing.

WodansSon

@yupwei68 Almost there, I think there was a search and replace error, but get those two issues fixed up and this resource LGTM! 🚀

azurerm/internal/services/iothub/iothub_digital_twins_resource.go

yupwei68 · 2020-11-23T06:36:02Z

@WodansSon Sorry for the mistakes. Please continue reviewing.

WodansSon

@yupwei68 Thanks for pushing those changes, this LGTM now! 🚀

WodansSon · 2020-11-23T11:25:36Z

tombuildsstuff · 2020-11-23T12:21:21Z

azurerm/internal/services/iothub/validate/digital_twins.go

+	}
+
+	if !regexp.MustCompile(`^[A-Za-z0-9][A-Za-z0-9-]+[A-Za-z0-9]$`).MatchString(v) {
+		errors = append(errors, fmt.Errorf("expected value of %s does not match regular expression, got %v", k, v))


this error message isn't helpful to users - can we explain the validation requirements here?

Fixed in PR #9430

tombuildsstuff · 2020-11-23T12:21:54Z

azurerm/internal/services/iothub/iothub_digital_twins_resource.go

+	if err != nil {
+		return err
+	}
+	d.SetId(id.ID(subscriptionId))


we can remove all of this in favour of using an ID Formatter directly here?

Fixed in PR #9430

tombuildsstuff · 2020-11-23T12:22:20Z

azurerm/internal/services/iothub/iothub_digital_twins_resource.go

+	}
+
+	if err := future.WaitForCompletionRef(ctx, client.Client); err != nil {
+		return fmt.Errorf("waiting on creating future for Digital Twins %q (Resource Group %q): %+v", name, resourceGroup, err)


this isn't meaningful to users - shouldn't this be "waiting for creation of Digital Twins.."?

Fixed in PR #9430

tombuildsstuff · 2020-11-23T12:22:47Z

azurerm/internal/services/iothub/iothub_digital_twins_resource.go

+		}
+	}
+	if existing.ID != nil && *existing.ID != "" {
+		return tf.ImportAsExistsError("azurerm_iothub_digital_twins", *existing.ID)


(as below) shouldn't this be using the ID Formatter to ensure it's consistent?

katbyte · 2020-11-23T18:10:55Z

azurerm/internal/services/iothub/client/client.go

@@ -1,6 +1,7 @@
 package client

 import (
+	"github.com/Azure/azure-sdk-for-go/services/digitaltwins/mgmt/2020-10-31/digitaltwins"


Actually why was this added to the iothub service? this is a new package import so shouldn't it be a new service package??

Fixed in PR #9430

katbyte · 2020-11-23T18:30:10Z

website/docs/r/iothub_digital_twins.html.markdown

+
+# azurerm_iothub_digital_twins
+
+Manages a Digital Twins.


Digital Twin what? instance? something else?

Fixed in PR #9430

katbyte · 2020-11-23T18:31:37Z

azurerm/internal/services/iothub/registration.go

@@ -21,6 +21,7 @@ func (r Registration) WebsiteCategories() []string {
 // SupportedDataSources returns the supported Data Sources supported by this Service
 func (r Registration) SupportedDataSources() map[string]*schema.Resource {
 	return map[string]*schema.Resource{
+		"azurerm_iothub_digital_twins":            dataSourceDigitalTwins(),


THis is a digital twin what? or will there not be any other resources for digital twins? azurerm_digital_twins_?????? instance?

Fixed in PR #9430

* Update name an move resource * Add Digital Twins to allowed subcategories * Update code to match refactor * Update WaitForCompletionRef error msgs * Updates per PR review

ghost · 2020-11-27T01:08:31Z

This has been released in version 2.38.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.38.0"
}
# ... other configuration ...

ghost · 2020-12-23T14:50:06Z

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

ArcturusZhang and others added 6 commits November 9, 2020 16:43

update azure-sdk-for-go to v47.0.0

ac21337

update

abb32ee

update

6a1fff4

update

ed8d18a

update

6cc7436

update

4dc05d1

ghost added size/XXL dependencies documentation labels Nov 9, 2020

fmt

104726c

manicminer added new-data-source new-resource service/iot-hub labels Nov 10, 2020

WodansSon requested changes Nov 17, 2020

View reviewed changes

review

97cc4ec

yupwei68 requested a review from WodansSon November 17, 2020 05:17

update

47a5ce4

WodansSon added this to the v2.38.0 milestone Nov 20, 2020

WodansSon requested changes Nov 23, 2020

View reviewed changes

azurerm/internal/services/iothub/iothub_digital_twins_resource.go Outdated Show resolved Hide resolved

azurerm/internal/services/iothub/iothub_digital_twins_resource.go Outdated Show resolved Hide resolved

update

f476565

yupwei68 requested a review from WodansSon November 23, 2020 06:36

WodansSon approved these changes Nov 23, 2020

View reviewed changes

WodansSon merged commit df18508 into hashicorp:master Nov 23, 2020

WodansSon added a commit that referenced this pull request Nov 23, 2020

Update to include #9212

5d83cf5

tombuildsstuff reviewed Nov 23, 2020

View reviewed changes

katbyte reviewed Nov 23, 2020

View reviewed changes

WodansSon mentioned this pull request Nov 24, 2020

azurerm_iothub_digital_twins -> azurerm_digital_twins_instance #9430

Merged

WodansSon added a commit that referenced this pull request Nov 25, 2020

Fix for #9212

cee2562

* Update name an move resource * Add Digital Twins to allowed subcategories * Update code to match refactor * Update WaitForCompletionRef error msgs * Updates per PR review

ghost locked as resolved and limited conversation to collaborators Dec 23, 2020

yupwei68 deleted the wyp-digitaltwins branch January 25, 2021 02:22

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New resource/ data source `azurerm_iothub_digital_twins` #9212

New resource/ data source `azurerm_iothub_digital_twins` #9212

yupwei68 commented Nov 9, 2020

WodansSon left a comment

yupwei68 commented Nov 17, 2020

WodansSon left a comment

yupwei68 commented Nov 23, 2020

WodansSon left a comment

WodansSon commented Nov 23, 2020

tombuildsstuff Nov 23, 2020

WodansSon Nov 24, 2020

tombuildsstuff Nov 23, 2020

WodansSon Nov 24, 2020

tombuildsstuff Nov 23, 2020

WodansSon Nov 24, 2020

tombuildsstuff Nov 23, 2020

katbyte Nov 23, 2020

WodansSon Nov 24, 2020

katbyte Nov 23, 2020

WodansSon Nov 24, 2020

katbyte Nov 23, 2020

WodansSon Nov 24, 2020

ghost commented Nov 27, 2020

ghost commented Dec 23, 2020

New resource/ data source azurerm_iothub_digital_twins #9212

New resource/ data source azurerm_iothub_digital_twins #9212

Conversation

yupwei68 commented Nov 9, 2020

WodansSon left a comment

Choose a reason for hiding this comment

yupwei68 commented Nov 17, 2020

WodansSon left a comment

Choose a reason for hiding this comment

yupwei68 commented Nov 23, 2020

WodansSon left a comment

Choose a reason for hiding this comment

WodansSon commented Nov 23, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ghost commented Nov 27, 2020

ghost commented Dec 23, 2020

New resource/ data source `azurerm_iothub_digital_twins` #9212

New resource/ data source `azurerm_iothub_digital_twins` #9212