-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update azurerm_api_management
- Support more cipher options
#9276
Merged
manicminer
merged 19 commits into
hashicorp:master
from
flo-02-mu:more-apim-cipher-flags
Jan 18, 2021
Merged
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
fc4a449
Add more cipher options to API management.
flo-02-mu aa8fd44
Add new cipher options to acc test.
flo-02-mu 29972d5
Rename cipher options to match allowed pattern
flo-02-mu 613fea4
Rename all cipher flags to match proposed convention.
flo-02-mu ff22d44
Merge branch 'master' into more-apim-cipher-flags
flo-02-mu 633c21a
Add deprecation fallback for enable_triple_des_ciphers
flo-02-mu db4e4bb
Fix path for deprecated triple des property
flo-02-mu 89d4e55
Merge remote-tracking branch 'upstream/master' into more-apim-cipher-…
flo-02-mu 002ef1b
Merge remote-tracking branch 'upstream/master' into more-apim-cipher-…
flo-02-mu 946499d
Update azurerm/internal/services/apimanagement/api_management_resourc…
flo-02-mu c57121f
Update azurerm/internal/services/apimanagement/api_management_resourc…
flo-02-mu 91acc48
Update azurerm/internal/services/apimanagement/api_management_resourc…
flo-02-mu cd34408
Update azurerm/internal/services/apimanagement/api_management_resourc…
flo-02-mu 937847a
Update azurerm/internal/services/apimanagement/api_management_resourc…
flo-02-mu 4a8635b
Remove non-existing property from documentation.
flo-02-mu 841568f
Update website/docs/r/api_management.html.markdown
flo-02-mu 668b0a1
azurerm_api_management: fix typo in test config
manicminer 22e4937
Exclude all cipher options for consumption sku
flo-02-mu 3cfe3db
azurerm_api_management: use Computed for deprecated attribute
manicminer File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@flo-02-mu You can maintain compatibility by keeping the existing property, adding the
Deprecated
field, and checking for both in theexpandApiManagementCustomProperties()
function (preferring the new one).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added. Not sure if the
d.GetOk(...)
works for the nested block as expected though.