Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds managed attribute to azurestack_availability_set #104

Merged
merged 2 commits into from
Aug 28, 2019

Conversation

petems
Copy link
Contributor

@petems petems commented Aug 21, 2019

Rebased from the original work by @jbmcfarlin31 👍

@petems
Copy link
Contributor Author

petems commented Aug 21, 2019

Removed mod/vendor updates, waiting on merge from #103

@petems petems force-pushed the add_managed_avaliablity_set branch from 7e40137 to ced6c1e Compare August 21, 2019 15:21
* Commented out, but new profile supports it
* Updated docs
* Unskip test
* Closes hashicorp#100
@petems petems force-pushed the add_managed_avaliablity_set branch from ced6c1e to 042e23a Compare August 21, 2019 18:16
@petems
Copy link
Contributor Author

petems commented Aug 21, 2019

Failing lint test fixed 😄

@katbyte katbyte added this to the v0.9.0 milestone Aug 28, 2019
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @petems, LGTM 👍

@katbyte katbyte merged commit 23077b5 into hashicorp:master Aug 28, 2019
katbyte added a commit that referenced this pull request Aug 29, 2019
@ghost
Copy link

ghost commented Aug 30, 2019

This has been released in version 0.9.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurestack" {
    version = "~> 0.9.0"
}
# ... other configuration ...

@petems petems deleted the add_managed_avaliablity_set branch September 3, 2019 22:07
@ghost
Copy link

ghost commented Sep 28, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Sep 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sku "Aligned" not available for Availability Set
2 participants