Add warnings about custom role format for IAM bindings #1605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Modular Magician <[email protected]>
Signed-off-by: Modular Magician <[email protected]> Co-authored-by: Dana Hoffman <[email protected]>
…icorp#1586) Signed-off-by: Modular Magician <[email protected]> Co-authored-by: Dana Hoffman <[email protected]>
Signed-off-by: Modular Magician <[email protected]> Co-authored-by: Riley Karson <[email protected]>
…p#1588) Signed-off-by: Modular Magician <[email protected]> Co-authored-by: emily <[email protected]>
Signed-off-by: Modular Magician <[email protected]> Co-authored-by: Martin Nowak <[email protected]>
Signed-off-by: Modular Magician <[email protected]> Co-authored-by: Brian Hildebrandt <[email protected]>
Signed-off-by: Modular Magician <[email protected]>
Signed-off-by: Modular Magician <[email protected]> Co-authored-by: emily <[email protected]>
Signed-off-by: Modular Magician <[email protected]> Co-authored-by: emily <[email protected]>
ghost
added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to hashicorp/terraform-provider-google#5250
IAM bindings allow for empty members - this means we need to support import/read for IAM bindings that do not actually exist in the Policy. However, we can't tell this apart from a user specifying the wrong role, which will cause the import to succeed but an subsequent apply to create the binding.
Given the above expected but weird behavior, this PR:
Derived from GoogleCloudPlatform/magic-modules#2937